| Message ID | 20190705093612.21925-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | power: supply: isp1704: remove redundant assignment to variable ret | expand |
Hi, On Fri, Jul 05, 2019 at 10:36:12AM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The variable ret is being assigned with a value that is never > read and it is being updated later with a new value. The > assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- Thanks, queued. -- Sebastian > drivers/power/supply/isp1704_charger.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/supply/isp1704_charger.c b/drivers/power/supply/isp1704_charger.c > index b48cb7aba97b..4812ac1ff2df 100644 > --- a/drivers/power/supply/isp1704_charger.c > +++ b/drivers/power/supply/isp1704_charger.c > @@ -342,7 +342,7 @@ static inline int isp1704_test_ulpi(struct isp1704_charger *isp) > int vendor; > int product; > int i; > - int ret = -ENODEV; > + int ret; > > /* Test ULPI interface */ > ret = isp1704_write(isp, ULPI_SCRATCH, 0xaa); > -- > 2.20.1 >
diff --git a/drivers/power/supply/isp1704_charger.c b/drivers/power/supply/isp1704_charger.c index b48cb7aba97b..4812ac1ff2df 100644 --- a/drivers/power/supply/isp1704_charger.c +++ b/drivers/power/supply/isp1704_charger.c @@ -342,7 +342,7 @@ static inline int isp1704_test_ulpi(struct isp1704_charger *isp) int vendor; int product; int i; - int ret = -ENODEV; + int ret; /* Test ULPI interface */ ret = isp1704_write(isp, ULPI_SCRATCH, 0xaa);