| Message ID | 20190707223303.6755-10-digetx@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | More improvements for Tegra30 devfreq driver | expand |
On 19. 7. 8. 오전 7:32, Dmitry Osipenko wrote: > Governor could be stopped while boosting is active. We have assumption > that everything is reset on governor's restart, including the boosting > value, which was missed. > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > drivers/devfreq/tegra30-devfreq.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c > index d5d04c25023b..32fe95458ee7 100644 > --- a/drivers/devfreq/tegra30-devfreq.c > +++ b/drivers/devfreq/tegra30-devfreq.c > @@ -536,6 +536,9 @@ static void tegra_actmon_configure_device(struct tegra_devfreq *tegra, > { > u32 val = 0, target_freq; > > + /* we don't want boosting on restart */ nitpick. I think that following comment is proper in my case. In my case, I think 'we' expression is not good /* Reset the boost frequency on restart */ > + dev->boost_freq = 0; > + > target_freq = clk_get_rate(tegra->emc_clock) / KHZ; > dev->avg_count = target_freq * ACTMON_SAMPLING_PERIOD; > device_writel(dev, dev->avg_count, ACTMON_DEV_INIT_AVG); > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
16.07.2019 15:13, Chanwoo Choi пишет: > On 19. 7. 8. 오전 7:32, Dmitry Osipenko wrote: >> Governor could be stopped while boosting is active. We have assumption >> that everything is reset on governor's restart, including the boosting >> value, which was missed. >> >> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> >> --- >> drivers/devfreq/tegra30-devfreq.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c >> index d5d04c25023b..32fe95458ee7 100644 >> --- a/drivers/devfreq/tegra30-devfreq.c >> +++ b/drivers/devfreq/tegra30-devfreq.c >> @@ -536,6 +536,9 @@ static void tegra_actmon_configure_device(struct tegra_devfreq *tegra, >> { >> u32 val = 0, target_freq; >> >> + /* we don't want boosting on restart */ > > nitpick. > I think that following comment is proper in my case. > In my case, I think 'we' expression is not good > > /* Reset the boost frequency on restart */ Okay, I'll change the wording. >> + dev->boost_freq = 0; >> + >> target_freq = clk_get_rate(tegra->emc_clock) / KHZ; >> dev->avg_count = target_freq * ACTMON_SAMPLING_PERIOD; >> device_writel(dev, dev->avg_count, ACTMON_DEV_INIT_AVG); >> > > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > >
diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c index d5d04c25023b..32fe95458ee7 100644 --- a/drivers/devfreq/tegra30-devfreq.c +++ b/drivers/devfreq/tegra30-devfreq.c @@ -536,6 +536,9 @@ static void tegra_actmon_configure_device(struct tegra_devfreq *tegra, { u32 val = 0, target_freq; + /* we don't want boosting on restart */ + dev->boost_freq = 0; + target_freq = clk_get_rate(tegra->emc_clock) / KHZ; dev->avg_count = target_freq * ACTMON_SAMPLING_PERIOD; device_writel(dev, dev->avg_count, ACTMON_DEV_INIT_AVG);
Governor could be stopped while boosting is active. We have assumption that everything is reset on governor's restart, including the boosting value, which was missed. Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/devfreq/tegra30-devfreq.c | 3 +++ 1 file changed, 3 insertions(+)