| Message ID | 20190726231558.175130-2-saravanak@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | viresh kumar |
| Headers | show |
| Series | Introduce Bandwidth OPPs for interconnects | expand |
Quoting Saravana Kannan (2019-07-26 16:15:55) > diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt > index 76b6c79604a5..b1eb49d6eab0 100644 > --- a/Documentation/devicetree/bindings/opp/opp.txt > +++ b/Documentation/devicetree/bindings/opp/opp.txt > @@ -83,9 +83,14 @@ properties. > > Required properties: > - opp-hz: Frequency in Hz, expressed as a 64-bit big-endian integer. This is a > - required property for all device nodes but devices like power domains. The > - power domain nodes must have another (implementation dependent) property which > - uniquely identifies the OPP nodes. > + required property for all device nodes but for devices like power domains or s/but/except/ > + bandwidth opp tables. The power domain nodes must have another (implementation > + dependent) property which uniquely identifies the OPP nodes. The interconnect > + opps are required to have the opp-peak-KBps property. > + > +- opp-peak-KBps: Peak bandwidth in kilobytes per second, expressed as a 32-bit > + big-endian integer. This is a required property for all devices that don't > + have opp-hz. For example, bandwidth OPP tables for interconnect paths. > > Optional properties: > - opp-microvolt: voltage in micro Volts. > @@ -132,6 +137,10 @@ Optional properties: > - opp-level: A value representing the performance level of the device, > expressed as a 32-bit integer. > > +- opp-avg-KBps: Average bandwidth in kilobytes per second, expressed as a Shouldn't that be a lower case k? kBps? > + 32-bit big-endian integer. This property is only meaningful in OPP tables > + where opp-peak-KBps is present. > + > - clock-latency-ns: Specifies the maximum possible transition latency (in > nanoseconds) for switching to this OPP from any other OPP. > > diff --git a/Documentation/devicetree/bindings/property-units.txt b/Documentation/devicetree/bindings/property-units.txt > index e9b8360b3288..ef4c4a199efa 100644 > --- a/Documentation/devicetree/bindings/property-units.txt > +++ b/Documentation/devicetree/bindings/property-units.txt > @@ -41,3 +41,7 @@ Temperature > Pressure > ---------------------------------------- > -kpascal : kilopascal > + > +Throughput > +---------------------------------------- > +-KBps : kilobytes per second Same comment.
diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt index 76b6c79604a5..b1eb49d6eab0 100644 --- a/Documentation/devicetree/bindings/opp/opp.txt +++ b/Documentation/devicetree/bindings/opp/opp.txt @@ -83,9 +83,14 @@ properties. Required properties: - opp-hz: Frequency in Hz, expressed as a 64-bit big-endian integer. This is a - required property for all device nodes but devices like power domains. The - power domain nodes must have another (implementation dependent) property which - uniquely identifies the OPP nodes. + required property for all device nodes but for devices like power domains or + bandwidth opp tables. The power domain nodes must have another (implementation + dependent) property which uniquely identifies the OPP nodes. The interconnect + opps are required to have the opp-peak-KBps property. + +- opp-peak-KBps: Peak bandwidth in kilobytes per second, expressed as a 32-bit + big-endian integer. This is a required property for all devices that don't + have opp-hz. For example, bandwidth OPP tables for interconnect paths. Optional properties: - opp-microvolt: voltage in micro Volts. @@ -132,6 +137,10 @@ Optional properties: - opp-level: A value representing the performance level of the device, expressed as a 32-bit integer. +- opp-avg-KBps: Average bandwidth in kilobytes per second, expressed as a + 32-bit big-endian integer. This property is only meaningful in OPP tables + where opp-peak-KBps is present. + - clock-latency-ns: Specifies the maximum possible transition latency (in nanoseconds) for switching to this OPP from any other OPP. diff --git a/Documentation/devicetree/bindings/property-units.txt b/Documentation/devicetree/bindings/property-units.txt index e9b8360b3288..ef4c4a199efa 100644 --- a/Documentation/devicetree/bindings/property-units.txt +++ b/Documentation/devicetree/bindings/property-units.txt @@ -41,3 +41,7 @@ Temperature Pressure ---------------------------------------- -kpascal : kilopascal + +Throughput +---------------------------------------- +-KBps : kilobytes per second
Interconnects often quantify their performance points in terms of bandwidth. So, add opp-peak-KBps (required) and opp-avg-KBps (optional) to allow specifying Bandwidth OPP tables in DT. opp-peak-KBps is a required property that replace opp-hz for Bandwidth OPP tables. opp-avg-KBps is an optional property that can be used in Bandwidth OPP tables. Signed-off-by: Saravana Kannan <saravanak@google.com> --- Documentation/devicetree/bindings/opp/opp.txt | 15 ++++++++++++--- .../devicetree/bindings/property-units.txt | 4 ++++ 2 files changed, 16 insertions(+), 3 deletions(-)