| Message ID | 20190730162236.6063-19-digetx@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | More improvements for Tegra30 devfreq driver | expand |
On 19. 7. 31. 오전 1:22, Dmitry Osipenko wrote: > Add verbose definition for the client's device control register value that > makes ACTMON to stop monitoring of the device. > > Suggested-by: Chanwoo Choi <cw00.choi@samsung.com> > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > drivers/devfreq/tegra30-devfreq.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c > index 3543fba74b52..8adc0ff48b45 100644 > --- a/drivers/devfreq/tegra30-devfreq.c > +++ b/drivers/devfreq/tegra30-devfreq.c > @@ -35,6 +35,8 @@ > #define ACTMON_DEV_CTRL_CONSECUTIVE_ABOVE_WMARK_EN BIT(30) > #define ACTMON_DEV_CTRL_ENB BIT(31) > > +#define ACTMON_DEV_CTRL_STOP 0x00000000 > + > #define ACTMON_DEV_UPPER_WMARK 0x4 > #define ACTMON_DEV_LOWER_WMARK 0x8 > #define ACTMON_DEV_INIT_AVG 0xc > @@ -714,7 +716,7 @@ static void tegra_actmon_configure_device(struct tegra_devfreq *tegra, > > static void tegra_actmon_stop_device(struct tegra_devfreq_device *dev) > { > - device_writel(dev, 0x00000000, ACTMON_DEV_CTRL); > + device_writel(dev, ACTMON_DEV_CTRL_STOP, ACTMON_DEV_CTRL); > device_writel(dev, ACTMON_INTR_STATUS_CLEAR, ACTMON_DEV_INTR_STATUS); > } > > I think that you can combine it to patch11. When combining it to patch11, don't need to add the suggested-by tag. Thanks.
31.07.2019 3:37, Chanwoo Choi пишет: > On 19. 7. 31. 오전 1:22, Dmitry Osipenko wrote: >> Add verbose definition for the client's device control register value that >> makes ACTMON to stop monitoring of the device. >> >> Suggested-by: Chanwoo Choi <cw00.choi@samsung.com> >> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> >> --- >> drivers/devfreq/tegra30-devfreq.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c >> index 3543fba74b52..8adc0ff48b45 100644 >> --- a/drivers/devfreq/tegra30-devfreq.c >> +++ b/drivers/devfreq/tegra30-devfreq.c >> @@ -35,6 +35,8 @@ >> #define ACTMON_DEV_CTRL_CONSECUTIVE_ABOVE_WMARK_EN BIT(30) >> #define ACTMON_DEV_CTRL_ENB BIT(31) >> >> +#define ACTMON_DEV_CTRL_STOP 0x00000000 >> + >> #define ACTMON_DEV_UPPER_WMARK 0x4 >> #define ACTMON_DEV_LOWER_WMARK 0x8 >> #define ACTMON_DEV_INIT_AVG 0xc >> @@ -714,7 +716,7 @@ static void tegra_actmon_configure_device(struct tegra_devfreq *tegra, >> >> static void tegra_actmon_stop_device(struct tegra_devfreq_device *dev) >> { >> - device_writel(dev, 0x00000000, ACTMON_DEV_CTRL); >> + device_writel(dev, ACTMON_DEV_CTRL_STOP, ACTMON_DEV_CTRL); >> device_writel(dev, ACTMON_INTR_STATUS_CLEAR, ACTMON_DEV_INTR_STATUS); >> } >> >> > > I think that you can combine it to patch11. > When combining it to patch11, don't need to add the suggested-by tag. > Thanks. > Alright, will combine them in the next revision which I'll make once the rest of the patches will be reviewed.
diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c index 3543fba74b52..8adc0ff48b45 100644 --- a/drivers/devfreq/tegra30-devfreq.c +++ b/drivers/devfreq/tegra30-devfreq.c @@ -35,6 +35,8 @@ #define ACTMON_DEV_CTRL_CONSECUTIVE_ABOVE_WMARK_EN BIT(30) #define ACTMON_DEV_CTRL_ENB BIT(31) +#define ACTMON_DEV_CTRL_STOP 0x00000000 + #define ACTMON_DEV_UPPER_WMARK 0x4 #define ACTMON_DEV_LOWER_WMARK 0x8 #define ACTMON_DEV_INIT_AVG 0xc @@ -714,7 +716,7 @@ static void tegra_actmon_configure_device(struct tegra_devfreq *tegra, static void tegra_actmon_stop_device(struct tegra_devfreq_device *dev) { - device_writel(dev, 0x00000000, ACTMON_DEV_CTRL); + device_writel(dev, ACTMON_DEV_CTRL_STOP, ACTMON_DEV_CTRL); device_writel(dev, ACTMON_INTR_STATUS_CLEAR, ACTMON_DEV_INTR_STATUS); }
Add verbose definition for the client's device control register value that makes ACTMON to stop monitoring of the device. Suggested-by: Chanwoo Choi <cw00.choi@samsung.com> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/devfreq/tegra30-devfreq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)