| Message ID | 20190805194418.GA14438@embeddedor (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | power: supply: ab8500_charger: Mark expected switch fall-through | expand |
Hi, On Mon, Aug 05, 2019 at 02:44:18PM -0500, Gustavo A. R. Silva wrote: > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warning (Building: allmodconfig arm): > > drivers/power/supply/ab8500_charger.c:738:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- Thanks, queued. -- Sebastian > drivers/power/supply/ab8500_charger.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charger.c > index 30de448de802..1be75a2fed9b 100644 > --- a/drivers/power/supply/ab8500_charger.c > +++ b/drivers/power/supply/ab8500_charger.c > @@ -742,6 +742,7 @@ static int ab8500_charger_max_usb_curr(struct ab8500_charger *di, > USB_CH_IP_CUR_LVL_1P5; > break; > } > + /* else, fall through */ > case USB_STAT_HM_IDGND: > dev_err(di->dev, "USB Type - Charging not allowed\n"); > di->max_usb_in_curr.usb_type_max = USB_CH_IP_CUR_LVL_0P05; > -- > 2.22.0 >
diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charger.c index 30de448de802..1be75a2fed9b 100644 --- a/drivers/power/supply/ab8500_charger.c +++ b/drivers/power/supply/ab8500_charger.c @@ -742,6 +742,7 @@ static int ab8500_charger_max_usb_curr(struct ab8500_charger *di, USB_CH_IP_CUR_LVL_1P5; break; } + /* else, fall through */ case USB_STAT_HM_IDGND: dev_err(di->dev, "USB Type - Charging not allowed\n"); di->max_usb_in_curr.usb_type_max = USB_CH_IP_CUR_LVL_0P05;
Mark switch cases where we are expecting to fall through. This patch fixes the following warning (Building: allmodconfig arm): drivers/power/supply/ab8500_charger.c:738:6: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/power/supply/ab8500_charger.c | 1 + 1 file changed, 1 insertion(+)