diff mbox series

[v2,1/3] power_supply: Add additional health properties to the header

Message ID 20191029200201.24483-1-dmurphy@ti.com (mailing list archive)
State Not Applicable, archived
Headers show
Series [v2,1/3] power_supply: Add additional health properties to the header | expand

Commit Message

Dan Murphy Oct. 29, 2019, 8:01 p.m. UTC
Add HEALTH_WARM, HEALTH_COOL and HEALTH_HOT to the health enum.

Signed-off-by: Dan Murphy <dmurphy@ti.com>
---

v2 - No changes

 include/linux/power_supply.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Dan Murphy Dec. 9, 2019, 9:48 p.m. UTC | #1
Bump

On 10/29/19 3:01 PM, Dan Murphy wrote:
> Add HEALTH_WARM, HEALTH_COOL and HEALTH_HOT to the health enum.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
>
> v2 - No changes
>
>   include/linux/power_supply.h | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
> index 28413f737e7d..bd0d3225f245 100644
> --- a/include/linux/power_supply.h
> +++ b/include/linux/power_supply.h
> @@ -61,6 +61,9 @@ enum {
>   	POWER_SUPPLY_HEALTH_WATCHDOG_TIMER_EXPIRE,
>   	POWER_SUPPLY_HEALTH_SAFETY_TIMER_EXPIRE,
>   	POWER_SUPPLY_HEALTH_OVERCURRENT,
> +	POWER_SUPPLY_HEALTH_WARM,
> +	POWER_SUPPLY_HEALTH_COOL,
> +	POWER_SUPPLY_HEALTH_HOT,
>   };
>   
>   enum {
Sebastian Reichel Dec. 19, 2019, 5:19 p.m. UTC | #2
Hi Dan,

On Tue, Oct 29, 2019 at 03:01:59PM -0500, Dan Murphy wrote:
> Add HEALTH_WARM, HEALTH_COOL and HEALTH_HOT to the health enum.
> 
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---

This needs to update /sys/class/power_supply/<supply_name>/health
entry in Documentation/ABI/testing/sysfs-class-power. Also it needs
to update power_supply_health_text in drivers/power/supply/power_supply_sysfs.c.

-- Sebastian

> 
> v2 - No changes
> 
>  include/linux/power_supply.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
> index 28413f737e7d..bd0d3225f245 100644
> --- a/include/linux/power_supply.h
> +++ b/include/linux/power_supply.h
> @@ -61,6 +61,9 @@ enum {
>  	POWER_SUPPLY_HEALTH_WATCHDOG_TIMER_EXPIRE,
>  	POWER_SUPPLY_HEALTH_SAFETY_TIMER_EXPIRE,
>  	POWER_SUPPLY_HEALTH_OVERCURRENT,
> +	POWER_SUPPLY_HEALTH_WARM,
> +	POWER_SUPPLY_HEALTH_COOL,
> +	POWER_SUPPLY_HEALTH_HOT,
>  };
>  
>  enum {
> -- 
> 2.22.0.214.g8dca754b1e
>
Dan Murphy Jan. 7, 2020, 4:50 p.m. UTC | #3
Sebastian

On 12/19/19 11:19 AM, Sebastian Reichel wrote:
> Hi Dan,
>
> On Tue, Oct 29, 2019 at 03:01:59PM -0500, Dan Murphy wrote:
>> Add HEALTH_WARM, HEALTH_COOL and HEALTH_HOT to the health enum.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
> This needs to update /sys/class/power_supply/<supply_name>/health
> entry in Documentation/ABI/testing/sysfs-class-power. Also it needs

I noticed "Over Current" was missing from the ABI doc.  Do you want that 
addition in a separate patch or can I add it in my update?

Dan

<snip>
diff mbox series

Patch

diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
index 28413f737e7d..bd0d3225f245 100644
--- a/include/linux/power_supply.h
+++ b/include/linux/power_supply.h
@@ -61,6 +61,9 @@  enum {
 	POWER_SUPPLY_HEALTH_WATCHDOG_TIMER_EXPIRE,
 	POWER_SUPPLY_HEALTH_SAFETY_TIMER_EXPIRE,
 	POWER_SUPPLY_HEALTH_OVERCURRENT,
+	POWER_SUPPLY_HEALTH_WARM,
+	POWER_SUPPLY_HEALTH_COOL,
+	POWER_SUPPLY_HEALTH_HOT,
 };
 
 enum {