| Message ID | 20191204010506.159128-1-maowenan@huawei.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [-next] power: supply: ab8500: Drop pointless static qualifier in ab8500_btemp_batctrl_volt_to_res() | expand |
On Wed, Dec 04, 2019 at 09:05:06AM +0800, Mao Wenan wrote: > There is no need to have the 'T *v' variable static > since new value always be assigned before use it. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Mao Wenan <maowenan@huawei.com> > --- > drivers/power/supply/ab8500_btemp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/supply/ab8500_btemp.c b/drivers/power/supply/ab8500_btemp.c > index 909f0242bacb..d3d4f7327d1b 100644 > --- a/drivers/power/supply/ab8500_btemp.c > +++ b/drivers/power/supply/ab8500_btemp.c > @@ -180,7 +180,7 @@ static int ab8500_btemp_batctrl_volt_to_res(struct ab8500_btemp *di, > static int ab8500_btemp_read_batctrl_voltage(struct ab8500_btemp *di) > { > int vbtemp, ret; > - static int prev; > + int prev; No. We use it first on linux-next (yesterday). It needs to be static. regards, dan carpenter
On Wed, Dec 04, 2019 at 09:30:58AM +0300, Dan Carpenter wrote: > On Wed, Dec 04, 2019 at 09:05:06AM +0800, Mao Wenan wrote: > > There is no need to have the 'T *v' variable static > > since new value always be assigned before use it. > > > > Reported-by: Hulk Robot <hulkci@huawei.com> > > Signed-off-by: Mao Wenan <maowenan@huawei.com> > > --- > > drivers/power/supply/ab8500_btemp.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/power/supply/ab8500_btemp.c b/drivers/power/supply/ab8500_btemp.c > > index 909f0242bacb..d3d4f7327d1b 100644 > > --- a/drivers/power/supply/ab8500_btemp.c > > +++ b/drivers/power/supply/ab8500_btemp.c > > @@ -180,7 +180,7 @@ static int ab8500_btemp_batctrl_volt_to_res(struct ab8500_btemp *di, > > static int ab8500_btemp_read_batctrl_voltage(struct ab8500_btemp *di) > > { > > int vbtemp, ret; > > - static int prev; > > + int prev; > > No. We use it first on linux-next (yesterday). It needs to be static. > It's surprising that your patch didn't cause an uninitialized variable compile warning for you. regards, dan carpenter
diff --git a/drivers/power/supply/ab8500_btemp.c b/drivers/power/supply/ab8500_btemp.c index 909f0242bacb..d3d4f7327d1b 100644 --- a/drivers/power/supply/ab8500_btemp.c +++ b/drivers/power/supply/ab8500_btemp.c @@ -180,7 +180,7 @@ static int ab8500_btemp_batctrl_volt_to_res(struct ab8500_btemp *di, static int ab8500_btemp_read_batctrl_voltage(struct ab8500_btemp *di) { int vbtemp, ret; - static int prev; + int prev; ret = iio_read_channel_processed(di->bat_ctrl, &vbtemp); if (ret < 0) {
There is no need to have the 'T *v' variable static since new value always be assigned before use it. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Mao Wenan <maowenan@huawei.com> --- drivers/power/supply/ab8500_btemp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)