| Message ID | 20191206101129.15232-1-k.konieczny@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | devfreq: move declaration of DEVICE_ATTR_RW(min_freq) | expand |
Hi Kamil, Looks good to me. Applied it. On later, better to add 'PM / ' prefix for patch title and use capital char for first word as following: devfreq: move declaration of DEVICE_ATTR_RW(min_freq) -> PM / devfreq: Move declaration of DEVICE_ATTR_RW(min_freq) On 12/6/19 7:11 PM, Kamil Konieczny wrote: > Declaration of DEVICE_ATTR_RW(min_freq) is placed after function > max_freq_store. Move it to the correct place after min_freq_show. > > Signed-off-by: Kamil Konieczny <k.konieczny@samsung.com> > --- > drivers/devfreq/devfreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c > index 1786a86b1779..46a7ff7c2994 100644 > --- a/drivers/devfreq/devfreq.c > +++ b/drivers/devfreq/devfreq.c > @@ -1368,6 +1368,7 @@ static ssize_t min_freq_show(struct device *dev, struct device_attribute *attr, > > return sprintf(buf, "%lu\n", min_freq); > } > +static DEVICE_ATTR_RW(min_freq); > > static ssize_t max_freq_store(struct device *dev, struct device_attribute *attr, > const char *buf, size_t count) > @@ -1391,7 +1392,6 @@ static ssize_t max_freq_store(struct device *dev, struct device_attribute *attr, > > return count; > } > -static DEVICE_ATTR_RW(min_freq); > > static ssize_t max_freq_show(struct device *dev, struct device_attribute *attr, > char *buf) >
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index 1786a86b1779..46a7ff7c2994 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -1368,6 +1368,7 @@ static ssize_t min_freq_show(struct device *dev, struct device_attribute *attr, return sprintf(buf, "%lu\n", min_freq); } +static DEVICE_ATTR_RW(min_freq); static ssize_t max_freq_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) @@ -1391,7 +1392,6 @@ static ssize_t max_freq_store(struct device *dev, struct device_attribute *attr, return count; } -static DEVICE_ATTR_RW(min_freq); static ssize_t max_freq_show(struct device *dev, struct device_attribute *attr, char *buf)
Declaration of DEVICE_ATTR_RW(min_freq) is placed after function max_freq_store. Move it to the correct place after min_freq_show. Signed-off-by: Kamil Konieczny <k.konieczny@samsung.com> --- drivers/devfreq/devfreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)