| Message ID | 20191211125411.1857250-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Chanwoo Choi |
| Headers | show |
| Series | PM / devfreq: tegra: add COMMON_CLK dependency | expand |
11.12.2019 15:54, Arnd Bergmann пишет: > Compile-testing this driver fails if CONFIG_COMMON_CLK is not set: > > drivers/devfreq/tegra30-devfreq.o: In function `tegra_devfreq_target': > tegra30-devfreq.c:(.text+0x164): undefined reference to `clk_set_min_rate' > > Fixes: 35f8dbc72721 ("PM / devfreq: tegra: Enable COMPILE_TEST for the driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/devfreq/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig > index defe1d438710..f712c3de0876 100644 > --- a/drivers/devfreq/Kconfig > +++ b/drivers/devfreq/Kconfig > @@ -98,6 +98,7 @@ config ARM_TEGRA_DEVFREQ > ARCH_TEGRA_132_SOC || ARCH_TEGRA_124_SOC || \ > ARCH_TEGRA_210_SOC || \ > COMPILE_TEST > + depends on COMMON_CLK > select PM_OPP > help > This adds the DEVFREQ driver for the Tegra family of SoCs. > Hello Arnd, I was about to send the same change because Geert Uytterhoeven reported the problem a day ago [1], but you beat me to it. [1] https://www.spinics.net/lists/linux-tegra/msg46169.html Thank you very much for the patch! Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
On 12/11/19 9:54 PM, Arnd Bergmann wrote: > Compile-testing this driver fails if CONFIG_COMMON_CLK is not set: > > drivers/devfreq/tegra30-devfreq.o: In function `tegra_devfreq_target': > tegra30-devfreq.c:(.text+0x164): undefined reference to `clk_set_min_rate' > > Fixes: 35f8dbc72721 ("PM / devfreq: tegra: Enable COMPILE_TEST for the driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/devfreq/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig > index defe1d438710..f712c3de0876 100644 > --- a/drivers/devfreq/Kconfig > +++ b/drivers/devfreq/Kconfig > @@ -98,6 +98,7 @@ config ARM_TEGRA_DEVFREQ > ARCH_TEGRA_132_SOC || ARCH_TEGRA_124_SOC || \ > ARCH_TEGRA_210_SOC || \ > COMPILE_TEST > + depends on COMMON_CLK > select PM_OPP > help > This adds the DEVFREQ driver for the Tegra family of SoCs. > Applied it. Thanks.
diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig index defe1d438710..f712c3de0876 100644 --- a/drivers/devfreq/Kconfig +++ b/drivers/devfreq/Kconfig @@ -98,6 +98,7 @@ config ARM_TEGRA_DEVFREQ ARCH_TEGRA_132_SOC || ARCH_TEGRA_124_SOC || \ ARCH_TEGRA_210_SOC || \ COMPILE_TEST + depends on COMMON_CLK select PM_OPP help This adds the DEVFREQ driver for the Tegra family of SoCs.
Compile-testing this driver fails if CONFIG_COMMON_CLK is not set: drivers/devfreq/tegra30-devfreq.o: In function `tegra_devfreq_target': tegra30-devfreq.c:(.text+0x164): undefined reference to `clk_set_min_rate' Fixes: 35f8dbc72721 ("PM / devfreq: tegra: Enable COMPILE_TEST for the driver") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/devfreq/Kconfig | 1 + 1 file changed, 1 insertion(+)