| Message ID | 20200127200350.24465-3-sibis@codeaurora.org (mailing list archive) |
|---|---|
| State | RFC, archived |
| Headers | show |
| Series | DDR/L3 Scaling support on SDM845 and SC7180 SoCs | expand |
On Tue, Jan 28, 2020 at 01:33:42AM +0530, Sibi Sankar wrote: > Add SDM845 to cpufreq-dt-platdev blacklist. nit: you could mention that cpufreq is handled by the 'qcom-cpufreq-hw' driver. > > Signed-off-by: Sibi Sankar <sibis@codeaurora.org> > --- > drivers/cpufreq/cpufreq-dt-platdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c > index f2ae9cd455c17..5492cf3c9dc18 100644 > --- a/drivers/cpufreq/cpufreq-dt-platdev.c > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c > @@ -130,6 +130,7 @@ static const struct of_device_id blacklist[] __initconst = { > { .compatible = "qcom,apq8096", }, > { .compatible = "qcom,msm8996", }, > { .compatible = "qcom,qcs404", }, > + { .compatible = "qcom,sdm845", }, > > { .compatible = "st,stih407", }, > { .compatible = "st,stih410", }, Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Thanks for the review! On 2020-01-29 02:14, Matthias Kaehlcke wrote: > On Tue, Jan 28, 2020 at 01:33:42AM +0530, Sibi Sankar wrote: >> Add SDM845 to cpufreq-dt-platdev blacklist. > > nit: you could mention that cpufreq is handled by the > 'qcom-cpufreq-hw' driver. will add it in the next re-spin. > >> >> Signed-off-by: Sibi Sankar <sibis@codeaurora.org> >> --- >> drivers/cpufreq/cpufreq-dt-platdev.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c >> b/drivers/cpufreq/cpufreq-dt-platdev.c >> index f2ae9cd455c17..5492cf3c9dc18 100644 >> --- a/drivers/cpufreq/cpufreq-dt-platdev.c >> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c >> @@ -130,6 +130,7 @@ static const struct of_device_id blacklist[] >> __initconst = { >> { .compatible = "qcom,apq8096", }, >> { .compatible = "qcom,msm8996", }, >> { .compatible = "qcom,qcs404", }, >> + { .compatible = "qcom,sdm845", }, >> >> { .compatible = "st,stih407", }, >> { .compatible = "st,stih410", }, > > Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
On Tue, Jan 28, 2020 at 12:44:23PM -0800, Matthias Kaehlcke wrote: > On Tue, Jan 28, 2020 at 01:33:42AM +0530, Sibi Sankar wrote: > > Add SDM845 to cpufreq-dt-platdev blacklist. > > nit: you could mention that cpufreq is handled by the > 'qcom-cpufreq-hw' driver. > IIUC, these platforms get the OPP table from the firmware and there shouldn't be OPP entries in the DT. If not, why not fix that to avoid more confusion. Can we make cpu0_node_has_opp_v2_prop return false in short. -- Regards, Sudeep
Hey Sudeep, Thanks for the review! On 2020-01-30 17:10, Sudeep Holla wrote: > On Tue, Jan 28, 2020 at 12:44:23PM -0800, Matthias Kaehlcke wrote: >> On Tue, Jan 28, 2020 at 01:33:42AM +0530, Sibi Sankar wrote: >> > Add SDM845 to cpufreq-dt-platdev blacklist. >> >> nit: you could mention that cpufreq is handled by the >> 'qcom-cpufreq-hw' driver. >> > > IIUC, these platforms get the OPP table from the firmware and there > shouldn't > be OPP entries in the DT. If not, why not fix that to avoid more > confusion. > Can we make cpu0_node_has_opp_v2_prop return false in short. The entire point of the series is to define a way of identifying required opp-kBps values for L3/DDR at different cpu frequencies. The required-opps is chosen as the way of showcasing the dependencies. Hence the need to for a superset cpu opp-table consisting of all possible cpu freq values supported by the family of SoCs and enabling only the opps that are supported by the board from the values read back from firmware. > > -- > Regards, > Sudeep
diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c index f2ae9cd455c17..5492cf3c9dc18 100644 --- a/drivers/cpufreq/cpufreq-dt-platdev.c +++ b/drivers/cpufreq/cpufreq-dt-platdev.c @@ -130,6 +130,7 @@ static const struct of_device_id blacklist[] __initconst = { { .compatible = "qcom,apq8096", }, { .compatible = "qcom,msm8996", }, { .compatible = "qcom,qcs404", }, + { .compatible = "qcom,sdm845", }, { .compatible = "st,stih407", }, { .compatible = "st,stih410", },
Add SDM845 to cpufreq-dt-platdev blacklist. Signed-off-by: Sibi Sankar <sibis@codeaurora.org> --- drivers/cpufreq/cpufreq-dt-platdev.c | 1 + 1 file changed, 1 insertion(+)