From patchwork Mon Feb 24 22:40:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Osipenko X-Patchwork-Id: 11401933 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B0C01924 for ; Mon, 24 Feb 2020 22:43:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 90B9222464 for ; Mon, 24 Feb 2020 22:43:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l0bwjGD5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727459AbgBXWnX (ORCPT ); Mon, 24 Feb 2020 17:43:23 -0500 Received: from mail-lf1-f65.google.com ([209.85.167.65]:46813 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728347AbgBXWms (ORCPT ); Mon, 24 Feb 2020 17:42:48 -0500 Received: by mail-lf1-f65.google.com with SMTP id u2so5355700lfk.13; Mon, 24 Feb 2020 14:42:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cRfDY6o3JLtgU0E8AhwXsc4tadD+Z274NBI7QDEmKc0=; b=l0bwjGD5lP1/kKdENiUvJpnEe46PGmODo54ldG8Nn/hn5AqZ0QZsaFHVGdFuw0W3ga dYKPi0HoCKLSZp8D37kDa+TeuSAWjMhrLSiQ8nhJ7NEIzdE/2PIcKou04mnPE18MYrTk iVUNcWGLpVcRaatDmYiWRW3oK8DPn/AYbH52fPAQtmShrgCfXoxlsUWXgGTbSybtG65y fnFkmOAsTv6uQ/mB317SKgrFKSqvnt7d3zwJv47YyU2eTp4u79coppYiagOZmoS9JJyp 8Yv6lB+Yo30rKD8UrZrjsGZqlwFN+QJoyyKSrIHjovh3GNnzW86SMRHvSKeYomOtEtCT KLnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cRfDY6o3JLtgU0E8AhwXsc4tadD+Z274NBI7QDEmKc0=; b=fK7PGnK4hernRuVGq57/wgv/N+y12kLRqcuoUw6T7Q9XyF2grLwXvESHfMY/MSKbLo hAAUv2oY3ZD1hjXTSRqRpCL9GtwJB5lJ3dDyImPJWhnn6xVRhvmvYxn2kk52F4bPj5Ds VO8cS407SB4i7lF5drl7/sdrbmtm5KHuoze7Kuj8dzDIHGUvv7ukjNYi4JfsSb9tPiLi MX04GdHeJ9a79499wHQ1ClWQBd3iBBr0KRuc3ky6MYy4/olMwhiegnInZ6QdwXATOYx5 r1D64HpAlv2GUdXiFxejiLSTpVU4SekJRayNROY72yhnbwcfzag3k2FjKJyd0vj426r+ YlrQ== X-Gm-Message-State: APjAAAW+ZymS4FCmYXHI3G66x1anwd7bAFLgRo0w2YUl7v1CULeRGu4W Utg4nqB2vzEMC3TLPfGYQPA= X-Google-Smtp-Source: APXvYqyiEo42FEGINsJwrlFM47li49pvziubmyXDSxiDbXkU50bgs4t6+l4qei0sFjfyNOhLuJoPrA== X-Received: by 2002:ac2:53b3:: with SMTP id j19mr15273156lfh.127.1582584165819; Mon, 24 Feb 2020 14:42:45 -0800 (PST) Received: from localhost.localdomain (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.gmail.com with ESMTPSA id j7sm6264833lfh.25.2020.02.24.14.42.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2020 14:42:45 -0800 (PST) From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Peter De Schrijver , "Rafael J. Wysocki" , Daniel Lezcano , =?utf-8?b?TWljaGHFgiBNaXJvc8WC?= =?utf-8?b?YXc=?= , Jasper Korten , David Heidelberg , Peter Geis , Nicolas Chauvet Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v11 11/17] arm: tegra20/30: cpuidle: Remove unnecessary memory barrier Date: Tue, 25 Feb 2020 01:40:51 +0300 Message-Id: <20200224224057.21877-12-digetx@gmail.com> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20200224224057.21877-1-digetx@gmail.com> References: <20200224224057.21877-1-digetx@gmail.com> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org There is no good justification for smp_rmb() after returning from LP2 because there are no memory operations that require SMP synchronization. Thus remove the confusing barrier. Acked-by: Peter De Schrijver Tested-by: Peter Geis Tested-by: Jasper Korten Tested-by: David Heidelberg Tested-by: Nicolas Chauvet Acked-by: Daniel Lezcano Signed-off-by: Dmitry Osipenko --- arch/arm/mach-tegra/cpuidle-tegra20.c | 2 -- arch/arm/mach-tegra/cpuidle-tegra30.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/arch/arm/mach-tegra/cpuidle-tegra20.c b/arch/arm/mach-tegra/cpuidle-tegra20.c index 8cdffdf7acd7..6db380515a6a 100644 --- a/arch/arm/mach-tegra/cpuidle-tegra20.c +++ b/arch/arm/mach-tegra/cpuidle-tegra20.c @@ -197,8 +197,6 @@ static int tegra20_idle_lp2_coupled(struct cpuidle_device *dev, local_fiq_enable(); - smp_rmb(); - return entered_lp2 ? index : 0; } #endif diff --git a/arch/arm/mach-tegra/cpuidle-tegra30.c b/arch/arm/mach-tegra/cpuidle-tegra30.c index a4f0add46a27..80ae64bcdf50 100644 --- a/arch/arm/mach-tegra/cpuidle-tegra30.c +++ b/arch/arm/mach-tegra/cpuidle-tegra30.c @@ -113,8 +113,6 @@ static int tegra30_idle_lp2(struct cpuidle_device *dev, local_fiq_enable(); - smp_rmb(); - return (entered_lp2) ? index : 0; } #endif