| Message ID | 20200303150749.30566-5-ulf.hansson@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | dt-bindings: arm: Fix bindings used for hierarchical PSCI states | expand |
On Tue, Mar 03, 2020 at 04:07:46PM +0100, Ulf Hansson wrote: > The existing binding requires the nodename to have a '@', which is a bit > limiting for the wider use case. Therefore, let's extend the pattern to > allow either '@' or '-'. That's fine, but... > Additionally, let's update one of the examples to show how the updated > pattern could be used. > > Fixes: a3f048b5424e ("dt: psci: Update DT bindings to support hierarchical PSCI states") > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > Documentation/devicetree/bindings/power/power-domain.yaml | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/power/power-domain.yaml b/Documentation/devicetree/bindings/power/power-domain.yaml > index 207e63ae10f9..dc232759013e 100644 > --- a/Documentation/devicetree/bindings/power/power-domain.yaml > +++ b/Documentation/devicetree/bindings/power/power-domain.yaml > @@ -25,7 +25,7 @@ description: |+ > > properties: > $nodename: > - pattern: "^(power-controller|power-domain)(@.*)?$" > + pattern: "^(power-controller|power-domain)([@-].*)?$" > > domain-idle-states: > $ref: /schemas/types.yaml#/definitions/phandle-array > @@ -71,13 +71,13 @@ required: > > examples: > - | > - power: power-controller@12340000 { > - compatible = "foo,power-controller"; > + power: power-domain-foo { > + compatible = "foo,power-domain"; > reg = <0x12340000 0x1000>; When you have 'reg' you should have a unit-address. > #power-domain-cells = <1>; > }; > > - // The node above defines a power controller that is a PM domain provider and > + // The node above defines a power domain that is a PM domain provider and > // expects one cell as its phandle argument. > > - | > -- > 2.20.1 >
On Tue, 3 Mar 2020 at 18:04, Rob Herring <robh@kernel.org> wrote: > > On Tue, Mar 03, 2020 at 04:07:46PM +0100, Ulf Hansson wrote: > > The existing binding requires the nodename to have a '@', which is a bit > > limiting for the wider use case. Therefore, let's extend the pattern to > > allow either '@' or '-'. > > That's fine, but... > > > Additionally, let's update one of the examples to show how the updated > > pattern could be used. > > > > Fixes: a3f048b5424e ("dt: psci: Update DT bindings to support hierarchical PSCI states") > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > > --- > > Documentation/devicetree/bindings/power/power-domain.yaml | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/power/power-domain.yaml b/Documentation/devicetree/bindings/power/power-domain.yaml > > index 207e63ae10f9..dc232759013e 100644 > > --- a/Documentation/devicetree/bindings/power/power-domain.yaml > > +++ b/Documentation/devicetree/bindings/power/power-domain.yaml > > @@ -25,7 +25,7 @@ description: |+ > > > > properties: > > $nodename: > > - pattern: "^(power-controller|power-domain)(@.*)?$" > > + pattern: "^(power-controller|power-domain)([@-].*)?$" > > > > domain-idle-states: > > $ref: /schemas/types.yaml#/definitions/phandle-array > > @@ -71,13 +71,13 @@ required: > > > > examples: > > - | > > - power: power-controller@12340000 { > > - compatible = "foo,power-controller"; > > + power: power-domain-foo { > > + compatible = "foo,power-domain"; > > reg = <0x12340000 0x1000>; > > When you have 'reg' you should have a unit-address. Yes, of course, thanks! [...] Kind regards Uffe
diff --git a/Documentation/devicetree/bindings/power/power-domain.yaml b/Documentation/devicetree/bindings/power/power-domain.yaml index 207e63ae10f9..dc232759013e 100644 --- a/Documentation/devicetree/bindings/power/power-domain.yaml +++ b/Documentation/devicetree/bindings/power/power-domain.yaml @@ -25,7 +25,7 @@ description: |+ properties: $nodename: - pattern: "^(power-controller|power-domain)(@.*)?$" + pattern: "^(power-controller|power-domain)([@-].*)?$" domain-idle-states: $ref: /schemas/types.yaml#/definitions/phandle-array @@ -71,13 +71,13 @@ required: examples: - | - power: power-controller@12340000 { - compatible = "foo,power-controller"; + power: power-domain-foo { + compatible = "foo,power-domain"; reg = <0x12340000 0x1000>; #power-domain-cells = <1>; }; - // The node above defines a power controller that is a PM domain provider and + // The node above defines a power domain that is a PM domain provider and // expects one cell as its phandle argument. - |
The existing binding requires the nodename to have a '@', which is a bit limiting for the wider use case. Therefore, let's extend the pattern to allow either '@' or '-'. Additionally, let's update one of the examples to show how the updated pattern could be used. Fixes: a3f048b5424e ("dt: psci: Update DT bindings to support hierarchical PSCI states") Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> --- Documentation/devicetree/bindings/power/power-domain.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)