diff mbox series

cpufreq/pstate: Only mention the BIOS disabling turbo mode once

Message ID 20200410192629.6779-1-chris@chris-wilson.co.uk (mailing list archive)
State Mainlined, archived
Headers show
Series cpufreq/pstate: Only mention the BIOS disabling turbo mode once | expand

Commit Message

Chris Wilson April 10, 2020, 7:26 p.m. UTC
Make a note of the first time we discover the turbo mode has been
disabled by the BIOS, as otherwise we complain every time we try to
update the mode.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Len Brown <lenb@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/cpufreq/intel_pstate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rafael J. Wysocki April 26, 2020, 3:02 p.m. UTC | #1
On Friday, April 10, 2020 9:26:29 PM CEST Chris Wilson wrote:
> Make a note of the first time we discover the turbo mode has been
> disabled by the BIOS, as otherwise we complain every time we try to
> update the mode.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: Len Brown <lenb@kernel.org>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> ---
>  drivers/cpufreq/intel_pstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index c81e1ff29069..b4c014464a20 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -1058,7 +1058,7 @@ static ssize_t store_no_turbo(struct kobject *a, struct kobj_attribute *b,
>  
>  	update_turbo_state();
>  	if (global.turbo_disabled) {
> -		pr_warn("Turbo disabled by BIOS or unavailable on processor\n");
> +		pr_notice_once("Turbo disabled by BIOS or unavailable on processor\n");
>  		mutex_unlock(&intel_pstate_limits_lock);
>  		mutex_unlock(&intel_pstate_driver_lock);
>  		return -EPERM;
> 

Applied as a fix for 5.7-rc4, sorry for the delay.

Thanks!
diff mbox series

Patch

diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index c81e1ff29069..b4c014464a20 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -1058,7 +1058,7 @@  static ssize_t store_no_turbo(struct kobject *a, struct kobj_attribute *b,
 
 	update_turbo_state();
 	if (global.turbo_disabled) {
-		pr_warn("Turbo disabled by BIOS or unavailable on processor\n");
+		pr_notice_once("Turbo disabled by BIOS or unavailable on processor\n");
 		mutex_unlock(&intel_pstate_limits_lock);
 		mutex_unlock(&intel_pstate_driver_lock);
 		return -EPERM;