| Message ID | 20200413141051.506784-1-enric.balletbo@collabora.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | power: supply: bq24257_charger: Replace depends on REGMAP_I2C with select | expand |
Hi, On Mon, Apr 13, 2020 at 04:10:51PM +0200, Enric Balletbo i Serra wrote: > regmap is a library function that gets selected by drivers that need > it. No driver modules should depend on it. Depending on REGMAP_I2C makes > this driver only build if another driver already selected REGMAP_I2C, > as the symbol can't be selected through the menu kernel configuration. > > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > --- Thanks, queued. -- Sebastian > drivers/power/supply/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig > index f3424fdce341..d37ec0d03237 100644 > --- a/drivers/power/supply/Kconfig > +++ b/drivers/power/supply/Kconfig > @@ -577,7 +577,7 @@ config CHARGER_BQ24257 > tristate "TI BQ24250/24251/24257 battery charger driver" > depends on I2C > depends on GPIOLIB || COMPILE_TEST > - depends on REGMAP_I2C > + select REGMAP_I2C > help > Say Y to enable support for the TI BQ24250, BQ24251, and BQ24257 battery > chargers.
diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig index f3424fdce341..d37ec0d03237 100644 --- a/drivers/power/supply/Kconfig +++ b/drivers/power/supply/Kconfig @@ -577,7 +577,7 @@ config CHARGER_BQ24257 tristate "TI BQ24250/24251/24257 battery charger driver" depends on I2C depends on GPIOLIB || COMPILE_TEST - depends on REGMAP_I2C + select REGMAP_I2C help Say Y to enable support for the TI BQ24250, BQ24251, and BQ24257 battery chargers.
regmap is a library function that gets selected by drivers that need it. No driver modules should depend on it. Depending on REGMAP_I2C makes this driver only build if another driver already selected REGMAP_I2C, as the symbol can't be selected through the menu kernel configuration. Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> --- drivers/power/supply/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)