| Message ID | 20200513185615.508236-2-sebastian.reichel@collabora.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Improve SBS battery support | expand |
On Wed, May 13, 2020 at 08:55:57PM +0200, Sebastian Reichel wrote: > SBS battery driver exposes 32 power supply properties now, > which will result in uevent failure on (un)plugging the > battery. Other drivers (e.g. bq27xxx) are also coming close > to this limit, so increase it. > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > --- > include/linux/kobject.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/kobject.h b/include/linux/kobject.h > index e2ca0a292e21..75e822569e39 100644 > --- a/include/linux/kobject.h > +++ b/include/linux/kobject.h > @@ -29,7 +29,7 @@ > #include <linux/uidgid.h> > > #define UEVENT_HELPER_PATH_LEN 256 > -#define UEVENT_NUM_ENVP 32 /* number of env pointers */ > +#define UEVENT_NUM_ENVP 64 /* number of env pointers */ > #define UEVENT_BUFFER_SIZE 2048 /* buffer for the variables */ > > #ifdef CONFIG_UEVENT_HELPER Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
On 2020/05/13, Sebastian Reichel wrote: > SBS battery driver exposes 32 power supply properties now, > which will result in uevent failure on (un)plugging the > battery. Other drivers (e.g. bq27xxx) are also coming close > to this limit, so increase it. > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > --- > include/linux/kobject.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/kobject.h b/include/linux/kobject.h > index e2ca0a292e21..75e822569e39 100644 > --- a/include/linux/kobject.h > +++ b/include/linux/kobject.h > @@ -29,7 +29,7 @@ > #include <linux/uidgid.h> > > #define UEVENT_HELPER_PATH_LEN 256 > -#define UEVENT_NUM_ENVP 32 /* number of env pointers */ > +#define UEVENT_NUM_ENVP 64 /* number of env pointers */ To be on the safe side I've checked systemd/udev. It's using ordered hashmap, so it's perfectly capable of handling the extra entries. Reviewed-by: Emil Velikov <emil.velikov@collabora.com> -Emil
diff --git a/include/linux/kobject.h b/include/linux/kobject.h index e2ca0a292e21..75e822569e39 100644 --- a/include/linux/kobject.h +++ b/include/linux/kobject.h @@ -29,7 +29,7 @@ #include <linux/uidgid.h> #define UEVENT_HELPER_PATH_LEN 256 -#define UEVENT_NUM_ENVP 32 /* number of env pointers */ +#define UEVENT_NUM_ENVP 64 /* number of env pointers */ #define UEVENT_BUFFER_SIZE 2048 /* buffer for the variables */ #ifdef CONFIG_UEVENT_HELPER
SBS battery driver exposes 32 power supply properties now, which will result in uevent failure on (un)plugging the battery. Other drivers (e.g. bq27xxx) are also coming close to this limit, so increase it. Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> --- include/linux/kobject.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)