| Message ID | 20200714142424.66648-1-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Headers | show |
| Series | [-next] cpuidle/pseries: Make symbol 'pseries_idle_driver' static | expand |
On Tue, Jul 14, 2020 at 4:14 PM Wei Yongjun <weiyongjun1@huawei.com> wrote: > > The sparse tool complains as follows: > > drivers/cpuidle/cpuidle-pseries.c:25:23: warning: > symbol 'pseries_idle_driver' was not declared. Should it be static? > > 'pseries_idle_driver' is not used outside of this file, so marks > it static. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/cpuidle/cpuidle-pseries.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpuidle/cpuidle-pseries.c b/drivers/cpuidle/cpuidle-pseries.c > index 6513ef2af66a..3e058ad2bb51 100644 > --- a/drivers/cpuidle/cpuidle-pseries.c > +++ b/drivers/cpuidle/cpuidle-pseries.c > @@ -22,7 +22,7 @@ > #include <asm/idle.h> > #include <asm/plpar_wrappers.h> > > -struct cpuidle_driver pseries_idle_driver = { > +static struct cpuidle_driver pseries_idle_driver = { > .name = "pseries_idle", > .owner = THIS_MODULE, > }; Applied as 5.9 material, thanks!
On Tue, 14 Jul 2020 22:24:24 +0800, Wei Yongjun wrote: > The sparse tool complains as follows: > > drivers/cpuidle/cpuidle-pseries.c:25:23: warning: > symbol 'pseries_idle_driver' was not declared. Should it be static? > > 'pseries_idle_driver' is not used outside of this file, so marks > it static. Applied to powerpc/next. [1/1] cpuidle/pseries: Make symbol 'pseries_idle_driver' static https://git.kernel.org/powerpc/c/92fe8483b1660feaa602d8be6ca7efe95ae4789b cheers
On 16/07/2020 14:56, Michael Ellerman wrote: > On Tue, 14 Jul 2020 22:24:24 +0800, Wei Yongjun wrote: >> The sparse tool complains as follows: >> >> drivers/cpuidle/cpuidle-pseries.c:25:23: warning: >> symbol 'pseries_idle_driver' was not declared. Should it be static? >> >> 'pseries_idle_driver' is not used outside of this file, so marks >> it static. > > Applied to powerpc/next. > > [1/1] cpuidle/pseries: Make symbol 'pseries_idle_driver' static > https://git.kernel.org/powerpc/c/92fe8483b1660feaa602d8be6ca7efe95ae4789b Rafael already picked the patch.
diff --git a/drivers/cpuidle/cpuidle-pseries.c b/drivers/cpuidle/cpuidle-pseries.c index 6513ef2af66a..3e058ad2bb51 100644 --- a/drivers/cpuidle/cpuidle-pseries.c +++ b/drivers/cpuidle/cpuidle-pseries.c @@ -22,7 +22,7 @@ #include <asm/idle.h> #include <asm/plpar_wrappers.h> -struct cpuidle_driver pseries_idle_driver = { +static struct cpuidle_driver pseries_idle_driver = { .name = "pseries_idle", .owner = THIS_MODULE, };
The sparse tool complains as follows: drivers/cpuidle/cpuidle-pseries.c:25:23: warning: symbol 'pseries_idle_driver' was not declared. Should it be static? 'pseries_idle_driver' is not used outside of this file, so marks it static. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/cpuidle/cpuidle-pseries.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)