From patchwork Wed Jul 15 08:26:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11664409 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 53F59913 for ; Wed, 15 Jul 2020 08:27:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3CF3F2075B for ; Wed, 15 Jul 2020 08:27:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wdxG8jLe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729908AbgGOI1Q (ORCPT ); Wed, 15 Jul 2020 04:27:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729877AbgGOI0s (ORCPT ); Wed, 15 Jul 2020 04:26:48 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0419C08C5C1 for ; Wed, 15 Jul 2020 01:26:47 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id j4so1437842wrp.10 for ; Wed, 15 Jul 2020 01:26:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4Z0fv79A73/vZIqM6ECnqpdpU/+7K2Y0w7fARWedt1c=; b=wdxG8jLedDYRfjs4gGzseOHpJxQaqy1oTFNhn/v43wZILfD7sUfWOlTF/WfpZ53GiT 9oirELAFbfOr4p5MsvB+3S3+PtP7e/IqharXV5TfUubJv6rBsfC9LqbdjWCx3fsWArRs RN3YAggQmoJk6eGn/MiyEbYw3IQ0k4T1WmIM+5/iLbtAJYlKiflIyr5p2Jtis7DbFJlz l+3GYbFdxmaVQCDR3DqZ7fiLFedXA2147Ou9CguKQ4q7pNY/y7oT+rcs2qaXJju7JgkL YgJfJG1bNq9KJ6W7Mt551x+CpJvCFlviz24zy1H4Bb9SL4Xv68oacZ7TTVxXCoVhg5mE Af6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4Z0fv79A73/vZIqM6ECnqpdpU/+7K2Y0w7fARWedt1c=; b=gEeiZwisnA+KWK1G0bBVatYVGWbbrbjxCY9MOQVhClxZHnM1X+Mi2t7AMZFUNsTxzT eGd6bBhRsiRvW0CSPQMPftIwXQZQGkjQ0tt4agjuKj9XV+x6D7ABSQh+MDdt1bt1z4RC RaOm7iOt/7PxNV37dkt2oydqHaEqCZqBZ89O4rf+YHWds4FizLCiUrOog60RjB+ymbFd 9de8n5mPyC8elPHeLDqtEuir5efpkcd1dNig6wov2PIGOU2SrpPPwOXNFAMBn6Buw2Dk Ob4WCh7cueh3dYFzy36Yuxm5ajM0R2nqTqRWRHknWt3A/0KywnXCKTGM6n6Y695WORFg Nb+Q== X-Gm-Message-State: AOAM533OYtteZBOPv8vUDE/pIzGuIwO5pOX1l8wjx4wTN7cr239jIusg l25MN9scidY6Sel4IO6sfMoT8g== X-Google-Smtp-Source: ABdhPJxYpuDnFCKTJN9z/Su7SsjnFEtm4WYtkojHvEEbT9vOYYaxPZnzu+/urdXDpBhf2vcZO8Fd6Q== X-Received: by 2002:a5d:5084:: with SMTP id a4mr10347220wrt.191.1594801606598; Wed, 15 Jul 2020 01:26:46 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id h13sm2400361wml.42.2020.07.15.01.26.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 01:26:46 -0700 (PDT) From: Lee Jones To: rjw@rjwysocki.net, viresh.kumar@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Lee Jones , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org Subject: [PATCH v2 07/13] cpufreq: powernv-cpufreq: Fix a bunch of kerneldoc related issues Date: Wed, 15 Jul 2020 09:26:28 +0100 Message-Id: <20200715082634.3024816-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715082634.3024816-1-lee.jones@linaro.org> References: <20200715082634.3024816-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Repair problems with formatting and missing attributes/parameters, and demote header comments which do not meet the required standards applicable to kerneldoc. Fixes the following W=1 kernel build warning(s): drivers/cpufreq/powernv-cpufreq.c:84: warning: Function parameter or member 'last_lpstate_idx' not described in 'global_pstate_info' drivers/cpufreq/powernv-cpufreq.c:84: warning: Function parameter or member 'last_gpstate_idx' not described in 'global_pstate_info' drivers/cpufreq/powernv-cpufreq.c:84: warning: Function parameter or member 'policy' not described in 'global_pstate_info' drivers/cpufreq/powernv-cpufreq.c:182: warning: Function parameter or member 'i' not described in 'idx_to_pstate' drivers/cpufreq/powernv-cpufreq.c:201: warning: Function parameter or member 'pstate' not described in 'pstate_to_idx' drivers/cpufreq/powernv-cpufreq.c:670: warning: Function parameter or member 't' not described in 'gpstate_timer_handler' drivers/cpufreq/powernv-cpufreq.c:670: warning: Excess function parameter 'data' description in 'gpstate_timer_handler' Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones Acked-by: Viresh Kumar --- drivers/cpufreq/powernv-cpufreq.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c index 068cc53abe320..2e5a8b8a4abaa 100644 --- a/drivers/cpufreq/powernv-cpufreq.c +++ b/drivers/cpufreq/powernv-cpufreq.c @@ -64,13 +64,14 @@ * highest_lpstate_idx * @last_sampled_time: Time from boot in ms when global pstates were * last set - * @last_lpstate_idx, Last set value of local pstate and global - * last_gpstate_idx pstate in terms of cpufreq table index + * @last_lpstate_idx: Last set value of local pstate and global + * @last_gpstate_idx: pstate in terms of cpufreq table index * @timer: Is used for ramping down if cpu goes idle for * a long time with global pstate held high * @gpstate_lock: A spinlock to maintain synchronization between * routines called by the timer handler and * governer's target_index calls + * @policy: Associated CPUFreq policy */ struct global_pstate_info { int highest_lpstate_idx; @@ -170,7 +171,7 @@ static inline u8 extract_pstate(u64 pmsr_val, unsigned int shift) /* Use following functions for conversions between pstate_id and index */ -/** +/* * idx_to_pstate : Returns the pstate id corresponding to the * frequency in the cpufreq frequency table * powernv_freqs indexed by @i. @@ -188,7 +189,7 @@ static inline u8 idx_to_pstate(unsigned int i) return powernv_freqs[i].driver_data; } -/** +/* * pstate_to_idx : Returns the index in the cpufreq frequencytable * powernv_freqs for the frequency whose corresponding * pstate id is @pstate. @@ -660,7 +661,7 @@ static inline void queue_gpstate_timer(struct global_pstate_info *gpstates) /** * gpstate_timer_handler * - * @data: pointer to cpufreq_policy on which timer was queued + * @t: Timer context used to fetch global pstate info struct * * This handler brings down the global pstate closer to the local pstate * according quadratic equation. Queues a new timer if it is still not equal