diff mbox series

MAINTAINERS: Update section for cpuidle-psci

Message ID 20200814123716.61936-1-ulf.hansson@linaro.org
State New
Headers show
Series MAINTAINERS: Update section for cpuidle-psci | expand

Commit Message

Ulf Hansson Aug. 14, 2020, 12:37 p.m. UTC
Extend the file pattern to also include cpuidle-psci.h and
cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer,
particularly to help with the support for PM domains.

Cc: Sudeep Holla <sudeep.holla@arm.com>
Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Rafael J. Wysocki Sept. 21, 2020, 3:49 p.m. UTC | #1
On Fri, Aug 14, 2020 at 2:37 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> Extend the file pattern to also include cpuidle-psci.h and
> cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer,
> particularly to help with the support for PM domains.
>
> Cc: Sudeep Holla <sudeep.holla@arm.com>
> Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

Any objections from the original maintainers?

> ---
>  MAINTAINERS | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f9ae8ea54e27..66821197175e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4556,10 +4556,11 @@ F:      drivers/cpuidle/cpuidle-exynos.c
>  CPUIDLE DRIVER - ARM PSCI
>  M:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>  M:     Sudeep Holla <sudeep.holla@arm.com>
> +M:     Ulf Hansson <ulf.hansson@linaro.org>
>  L:     linux-pm@vger.kernel.org
>  L:     linux-arm-kernel@lists.infradead.org
>  S:     Supported
> -F:     drivers/cpuidle/cpuidle-psci.c
> +F:     drivers/cpuidle/cpuidle-psci*
>
>  CRAMFS FILESYSTEM
>  M:     Nicolas Pitre <nico@fluxnic.net>
> --
> 2.25.1
>
Lorenzo Pieralisi Sept. 23, 2020, 8:11 a.m. UTC | #2
On Mon, Sep 21, 2020 at 05:49:52PM +0200, Rafael J. Wysocki wrote:
> On Fri, Aug 14, 2020 at 2:37 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> >
> > Extend the file pattern to also include cpuidle-psci.h and
> > cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer,
> > particularly to help with the support for PM domains.
> >
> > Cc: Sudeep Holla <sudeep.holla@arm.com>
> > Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>
> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> 
> Any objections from the original maintainers?

The PSCI driver providing support for platform coordinated idle states
(that this patch is targeting AFAICS) does not require more maintainers,
that support is complete and Sudeep and I will take care of refactoring
and fixes.

If the OSI bits in it require a specific maintainer I would prefer those
bits to be moved into a specific file and maintainership added
_explicitly_ for that file only.

Thanks,
Lorenzo

> >  MAINTAINERS | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index f9ae8ea54e27..66821197175e 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -4556,10 +4556,11 @@ F:      drivers/cpuidle/cpuidle-exynos.c
> >  CPUIDLE DRIVER - ARM PSCI
> >  M:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> >  M:     Sudeep Holla <sudeep.holla@arm.com>
> > +M:     Ulf Hansson <ulf.hansson@linaro.org>
> >  L:     linux-pm@vger.kernel.org
> >  L:     linux-arm-kernel@lists.infradead.org
> >  S:     Supported
> > -F:     drivers/cpuidle/cpuidle-psci.c
> > +F:     drivers/cpuidle/cpuidle-psci*
> >
> >  CRAMFS FILESYSTEM
> >  M:     Nicolas Pitre <nico@fluxnic.net>
> > --
> > 2.25.1
> >
Ulf Hansson Sept. 23, 2020, 1:44 p.m. UTC | #3
On Wed, 23 Sep 2020 at 10:11, Lorenzo Pieralisi
<lorenzo.pieralisi@arm.com> wrote:
>
> On Mon, Sep 21, 2020 at 05:49:52PM +0200, Rafael J. Wysocki wrote:
> > On Fri, Aug 14, 2020 at 2:37 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> > >
> > > Extend the file pattern to also include cpuidle-psci.h and
> > > cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer,
> > > particularly to help with the support for PM domains.
> > >
> > > Cc: Sudeep Holla <sudeep.holla@arm.com>
> > > Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>
> > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> >
> > Any objections from the original maintainers?
>
> The PSCI driver providing support for platform coordinated idle states
> (that this patch is targeting AFAICS) does not require more maintainers,
> that support is complete and Sudeep and I will take care of refactoring
> and fixes.
>
> If the OSI bits in it require a specific maintainer I would prefer those
> bits to be moved into a specific file and maintainership added
> _explicitly_ for that file only.

My main concern is that the OSI support (and some related changes for
genpd) is still being worked upon. The corresponding code deserves to
be looked after by someone. I offer my help with this.

I guess we can split up the code as you suggest, but perhaps another
way would be to explicitly state my part of the responsibility in
MAINTAINERS. Along the lines of this:

M:     Ulf Hansson <ulf.hansson@linaro.org> # OSI support / PM domains

Would that be okay to you?

Kind regards
Uffe

>
> Thanks,
> Lorenzo
>
> > >  MAINTAINERS | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index f9ae8ea54e27..66821197175e 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -4556,10 +4556,11 @@ F:      drivers/cpuidle/cpuidle-exynos.c
> > >  CPUIDLE DRIVER - ARM PSCI
> > >  M:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> > >  M:     Sudeep Holla <sudeep.holla@arm.com>
> > > +M:     Ulf Hansson <ulf.hansson@linaro.org>
> > >  L:     linux-pm@vger.kernel.org
> > >  L:     linux-arm-kernel@lists.infradead.org
> > >  S:     Supported
> > > -F:     drivers/cpuidle/cpuidle-psci.c
> > > +F:     drivers/cpuidle/cpuidle-psci*
> > >
> > >  CRAMFS FILESYSTEM
> > >  M:     Nicolas Pitre <nico@fluxnic.net>
> > > --
> > > 2.25.1
> > >
Lorenzo Pieralisi Sept. 30, 2020, 9:12 a.m. UTC | #4
On Wed, Sep 23, 2020 at 03:44:53PM +0200, Ulf Hansson wrote:
> On Wed, 23 Sep 2020 at 10:11, Lorenzo Pieralisi
> <lorenzo.pieralisi@arm.com> wrote:
> >
> > On Mon, Sep 21, 2020 at 05:49:52PM +0200, Rafael J. Wysocki wrote:
> > > On Fri, Aug 14, 2020 at 2:37 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> > > >
> > > > Extend the file pattern to also include cpuidle-psci.h and
> > > > cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer,
> > > > particularly to help with the support for PM domains.
> > > >
> > > > Cc: Sudeep Holla <sudeep.holla@arm.com>
> > > > Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>
> > > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> > >
> > > Any objections from the original maintainers?
> >
> > The PSCI driver providing support for platform coordinated idle states
> > (that this patch is targeting AFAICS) does not require more maintainers,
> > that support is complete and Sudeep and I will take care of refactoring
> > and fixes.
> >
> > If the OSI bits in it require a specific maintainer I would prefer those
> > bits to be moved into a specific file and maintainership added
> > _explicitly_ for that file only.
> 
> My main concern is that the OSI support (and some related changes for
> genpd) is still being worked upon. The corresponding code deserves to
> be looked after by someone. I offer my help with this.

All OSI changes can go into cpuidle-psci-domain.c, you can add a
maintainer entry for that.

> I guess we can split up the code as you suggest, but perhaps another
> way would be to explicitly state my part of the responsibility in
> MAINTAINERS. Along the lines of this:
> 
> M:     Ulf Hansson <ulf.hansson@linaro.org> # OSI support / PM domains
> 
> Would that be okay to you?

No because there should be no need, as I have already said. If you need
to change cpuidle-psci.c send patches please and we will review them.

Thanks,
Lorenzo

> > Thanks,
> > Lorenzo
> >
> > > >  MAINTAINERS | 3 ++-
> > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > index f9ae8ea54e27..66821197175e 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -4556,10 +4556,11 @@ F:      drivers/cpuidle/cpuidle-exynos.c
> > > >  CPUIDLE DRIVER - ARM PSCI
> > > >  M:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> > > >  M:     Sudeep Holla <sudeep.holla@arm.com>
> > > > +M:     Ulf Hansson <ulf.hansson@linaro.org>
> > > >  L:     linux-pm@vger.kernel.org
> > > >  L:     linux-arm-kernel@lists.infradead.org
> > > >  S:     Supported
> > > > -F:     drivers/cpuidle/cpuidle-psci.c
> > > > +F:     drivers/cpuidle/cpuidle-psci*
> > > >
> > > >  CRAMFS FILESYSTEM
> > > >  M:     Nicolas Pitre <nico@fluxnic.net>
> > > > --
> > > > 2.25.1
> > > >
Ulf Hansson Sept. 30, 2020, 9:46 a.m. UTC | #5
On Wed, 30 Sep 2020 at 11:13, Lorenzo Pieralisi
<lorenzo.pieralisi@arm.com> wrote:
>
> On Wed, Sep 23, 2020 at 03:44:53PM +0200, Ulf Hansson wrote:
> > On Wed, 23 Sep 2020 at 10:11, Lorenzo Pieralisi
> > <lorenzo.pieralisi@arm.com> wrote:
> > >
> > > On Mon, Sep 21, 2020 at 05:49:52PM +0200, Rafael J. Wysocki wrote:
> > > > On Fri, Aug 14, 2020 at 2:37 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> > > > >
> > > > > Extend the file pattern to also include cpuidle-psci.h and
> > > > > cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer,
> > > > > particularly to help with the support for PM domains.
> > > > >
> > > > > Cc: Sudeep Holla <sudeep.holla@arm.com>
> > > > > Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>
> > > > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> > > >
> > > > Any objections from the original maintainers?
> > >
> > > The PSCI driver providing support for platform coordinated idle states
> > > (that this patch is targeting AFAICS) does not require more maintainers,
> > > that support is complete and Sudeep and I will take care of refactoring
> > > and fixes.
> > >
> > > If the OSI bits in it require a specific maintainer I would prefer those
> > > bits to be moved into a specific file and maintainership added
> > > _explicitly_ for that file only.
> >
> > My main concern is that the OSI support (and some related changes for
> > genpd) is still being worked upon. The corresponding code deserves to
> > be looked after by someone. I offer my help with this.
>
> All OSI changes can go into cpuidle-psci-domain.c, you can add a
> maintainer entry for that.

Alright. Most of the things are already in there, but I will try to
move the rest as well then.

>
> > I guess we can split up the code as you suggest, but perhaps another
> > way would be to explicitly state my part of the responsibility in
> > MAINTAINERS. Along the lines of this:
> >
> > M:     Ulf Hansson <ulf.hansson@linaro.org> # OSI support / PM domains
> >
> > Would that be okay to you?
>
> No because there should be no need, as I have already said. If you need
> to change cpuidle-psci.c send patches please and we will review them.

I sent a small series "Enable s2idle when using PSCI OSI [1]" a month
ago, but haven't received any feedback. I guess moving all OSI parts
to cpuidle-psci-domain.c would help, as we wouldn't need to bother you
with these OSI specific things then.

[...]

Kind regards
Uffe

[1]
https://www.spinics.net/lists/arm-kernel/msg833933.html
Sudeep Holla Sept. 30, 2020, 10:16 a.m. UTC | #6
On Wed, Sep 30, 2020 at 10:12:54AM +0100, Lorenzo Pieralisi wrote:
> On Wed, Sep 23, 2020 at 03:44:53PM +0200, Ulf Hansson wrote:
> > On Wed, 23 Sep 2020 at 10:11, Lorenzo Pieralisi
> > <lorenzo.pieralisi@arm.com> wrote:
> > >
> > > On Mon, Sep 21, 2020 at 05:49:52PM +0200, Rafael J. Wysocki wrote:
> > > > On Fri, Aug 14, 2020 at 2:37 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> > > > >
> > > > > Extend the file pattern to also include cpuidle-psci.h and
> > > > > cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer,
> > > > > particularly to help with the support for PM domains.
> > > > >
> > > > > Cc: Sudeep Holla <sudeep.holla@arm.com>
> > > > > Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>
> > > > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> > > >
> > > > Any objections from the original maintainers?
> > >
> > > The PSCI driver providing support for platform coordinated idle states
> > > (that this patch is targeting AFAICS) does not require more maintainers,
> > > that support is complete and Sudeep and I will take care of refactoring
> > > and fixes.
> > >
> > > If the OSI bits in it require a specific maintainer I would prefer those
> > > bits to be moved into a specific file and maintainership added
> > > _explicitly_ for that file only.
> >
> > My main concern is that the OSI support (and some related changes for
> > genpd) is still being worked upon. The corresponding code deserves to
> > be looked after by someone. I offer my help with this.
>
> All OSI changes can go into cpuidle-psci-domain.c, you can add a
> maintainer entry for that.
>
> > I guess we can split up the code as you suggest, but perhaps another
> > way would be to explicitly state my part of the responsibility in
> > MAINTAINERS. Along the lines of this:
> >
> > M:     Ulf Hansson <ulf.hansson@linaro.org> # OSI support / PM domains
> >
> > Would that be okay to you?
>
> No because there should be no need, as I have already said. If you need
> to change cpuidle-psci.c send patches please and we will review them.
>

I agree and recollect that was the main idea when we moved all the OSI
specific PM domain code to separate file.

--
Regards,
Sudeep
Sudeep Holla Sept. 30, 2020, 10:18 a.m. UTC | #7
On Wed, Sep 30, 2020 at 11:46:19AM +0200, Ulf Hansson wrote:
> On Wed, 30 Sep 2020 at 11:13, Lorenzo Pieralisi
> <lorenzo.pieralisi@arm.com> wrote:
> >
> > On Wed, Sep 23, 2020 at 03:44:53PM +0200, Ulf Hansson wrote:
> > > On Wed, 23 Sep 2020 at 10:11, Lorenzo Pieralisi
> > > <lorenzo.pieralisi@arm.com> wrote:
> > > >
> > > > On Mon, Sep 21, 2020 at 05:49:52PM +0200, Rafael J. Wysocki wrote:
> > > > > On Fri, Aug 14, 2020 at 2:37 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> > > > > >
> > > > > > Extend the file pattern to also include cpuidle-psci.h and
> > > > > > cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer,
> > > > > > particularly to help with the support for PM domains.
> > > > > >
> > > > > > Cc: Sudeep Holla <sudeep.holla@arm.com>
> > > > > > Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>
> > > > > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> > > > >
> > > > > Any objections from the original maintainers?
> > > >
> > > > The PSCI driver providing support for platform coordinated idle states
> > > > (that this patch is targeting AFAICS) does not require more maintainers,
> > > > that support is complete and Sudeep and I will take care of refactoring
> > > > and fixes.
> > > >
> > > > If the OSI bits in it require a specific maintainer I would prefer those
> > > > bits to be moved into a specific file and maintainership added
> > > > _explicitly_ for that file only.
> > >
> > > My main concern is that the OSI support (and some related changes for
> > > genpd) is still being worked upon. The corresponding code deserves to
> > > be looked after by someone. I offer my help with this.
> >
> > All OSI changes can go into cpuidle-psci-domain.c, you can add a
> > maintainer entry for that.
>
> Alright. Most of the things are already in there, but I will try to
> move the rest as well then.
>
> >
> > > I guess we can split up the code as you suggest, but perhaps another
> > > way would be to explicitly state my part of the responsibility in
> > > MAINTAINERS. Along the lines of this:
> > >
> > > M:     Ulf Hansson <ulf.hansson@linaro.org> # OSI support / PM domains
> > >
> > > Would that be okay to you?
> >
> > No because there should be no need, as I have already said. If you need
> > to change cpuidle-psci.c send patches please and we will review them.
>
> I sent a small series "Enable s2idle when using PSCI OSI [1]" a month
> ago, but haven't received any feedback. I guess moving all OSI parts
> to cpuidle-psci-domain.c would help, as we wouldn't need to bother you
> with these OSI specific things then.
>

As I mentioned in one of the thread, I was confused with multiple series
at the same time and I believe there were S2I/S2R related patches from
you and one more person. I was confused and about to go on vacation.
I will take a look at it.

--
Regards,
Sudeep
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index f9ae8ea54e27..66821197175e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4556,10 +4556,11 @@  F:	drivers/cpuidle/cpuidle-exynos.c
 CPUIDLE DRIVER - ARM PSCI
 M:	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
 M:	Sudeep Holla <sudeep.holla@arm.com>
+M:	Ulf Hansson <ulf.hansson@linaro.org>
 L:	linux-pm@vger.kernel.org
 L:	linux-arm-kernel@lists.infradead.org
 S:	Supported
-F:	drivers/cpuidle/cpuidle-psci.c
+F:	drivers/cpuidle/cpuidle-psci*
 
 CRAMFS FILESYSTEM
 M:	Nicolas Pitre <nico@fluxnic.net>