| Message ID | 20200908201319.3567-4-krzk@kernel.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [1/7] dt-bindings: power: bq27xxx: add bq34z100 | expand |
Krzysztof On 9/8/20 3:13 PM, Krzysztof Kozlowski wrote: > BIT() is a preferred way to toggle bit-like flags: no problems with 32/64 > bit systems, less chances for mistakes. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > drivers/power/supply/bq27xxx_battery.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c > index 2deac3fbb036..e971af43dd45 100644 > --- a/drivers/power/supply/bq27xxx_battery.c > +++ b/drivers/power/supply/bq27xxx_battery.c > @@ -847,13 +847,14 @@ static struct bq27xxx_dm_reg bq27621_dm_regs[] = { > > #define bq27z561_dm_regs 0 > #define bq28z610_dm_regs 0 > - > -#define BQ27XXX_O_ZERO 0x00000001 > -#define BQ27XXX_O_OTDC 0x00000002 /* has OTC/OTD overtemperature flags */ > -#define BQ27XXX_O_UTOT 0x00000004 /* has OT overtemperature flag */ > -#define BQ27XXX_O_CFGUP 0x00000008 > -#define BQ27XXX_O_RAM 0x00000010 > -#define BQ27Z561_O_BITS 0x00000020 > +#define bq34z100_dm_regs 0 > + > +#define BQ27XXX_O_ZERO BIT(0) > +#define BQ27XXX_O_OTDC BIT(1) /* has OTC/OTD overtemperature flags */ > +#define BQ27XXX_O_UTOT BIT(2) /* has OT overtemperature flag */ > +#define BQ27XXX_O_CFGUP BIT(3) > +#define BQ27XXX_O_RAM BIT(4) > +#define BQ27Z561_O_BITS BIT(5) > It seems you have added whitespaces that you submitted a patch to fix in 3/7. Also squash 3 and 4. Dan
On Tue, 8 Sep 2020 at 22:53, Dan Murphy <dmurphy@ti.com> wrote: > > Krzysztof > > On 9/8/20 3:13 PM, Krzysztof Kozlowski wrote: > > BIT() is a preferred way to toggle bit-like flags: no problems with 32/64 > > bit systems, less chances for mistakes. > > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > --- > > drivers/power/supply/bq27xxx_battery.c | 15 ++++++++------- > > 1 file changed, 8 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c > > index 2deac3fbb036..e971af43dd45 100644 > > --- a/drivers/power/supply/bq27xxx_battery.c > > +++ b/drivers/power/supply/bq27xxx_battery.c > > @@ -847,13 +847,14 @@ static struct bq27xxx_dm_reg bq27621_dm_regs[] = { > > > > #define bq27z561_dm_regs 0 > > #define bq28z610_dm_regs 0 > > - > > -#define BQ27XXX_O_ZERO 0x00000001 > > -#define BQ27XXX_O_OTDC 0x00000002 /* has OTC/OTD overtemperature flags */ > > -#define BQ27XXX_O_UTOT 0x00000004 /* has OT overtemperature flag */ > > -#define BQ27XXX_O_CFGUP 0x00000008 > > -#define BQ27XXX_O_RAM 0x00000010 > > -#define BQ27Z561_O_BITS 0x00000020 > > +#define bq34z100_dm_regs 0 > > + > > +#define BQ27XXX_O_ZERO BIT(0) > > +#define BQ27XXX_O_OTDC BIT(1) /* has OTC/OTD overtemperature flags */ > > +#define BQ27XXX_O_UTOT BIT(2) /* has OT overtemperature flag */ > > +#define BQ27XXX_O_CFGUP BIT(3) > > +#define BQ27XXX_O_RAM BIT(4) > > +#define BQ27Z561_O_BITS BIT(5) > > > > It seems you have added whitespaces that you submitted a patch to fix in > 3/7. I shouldn't... 3/7 is different #define: BQ27Z561_FLAG_FC Here it might look like not indented properly due to the patch format. In the file, when applying, the entries are aligned correctly. > > Also squash 3 and 4. Whitespace with BIT conversion? Sure, I can. These are separate places and different types of cleanup, but no problem to squash them. Best regards, Krzysztof
diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c index 2deac3fbb036..e971af43dd45 100644 --- a/drivers/power/supply/bq27xxx_battery.c +++ b/drivers/power/supply/bq27xxx_battery.c @@ -847,13 +847,14 @@ static struct bq27xxx_dm_reg bq27621_dm_regs[] = { #define bq27z561_dm_regs 0 #define bq28z610_dm_regs 0 - -#define BQ27XXX_O_ZERO 0x00000001 -#define BQ27XXX_O_OTDC 0x00000002 /* has OTC/OTD overtemperature flags */ -#define BQ27XXX_O_UTOT 0x00000004 /* has OT overtemperature flag */ -#define BQ27XXX_O_CFGUP 0x00000008 -#define BQ27XXX_O_RAM 0x00000010 -#define BQ27Z561_O_BITS 0x00000020 +#define bq34z100_dm_regs 0 + +#define BQ27XXX_O_ZERO BIT(0) +#define BQ27XXX_O_OTDC BIT(1) /* has OTC/OTD overtemperature flags */ +#define BQ27XXX_O_UTOT BIT(2) /* has OT overtemperature flag */ +#define BQ27XXX_O_CFGUP BIT(3) +#define BQ27XXX_O_RAM BIT(4) +#define BQ27Z561_O_BITS BIT(5) #define BQ27XXX_DATA(ref, key, opt) { \ .opts = (opt), \
BIT() is a preferred way to toggle bit-like flags: no problems with 32/64 bit systems, less chances for mistakes. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/power/supply/bq27xxx_battery.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-)