| Message ID | 20201027102731.951421-1-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | interconnect: qcom: use icc_sync state for sm8[12]50 | expand |
Hi Dmitry, Thanks for the patch! On 10/27/20 12:27, Dmitry Baryshkov wrote: > In addition to the rest of Qcom interconnect drivers use icc_sync_state > for SM8150/SM8250 interconnect drivers to notify the interconnect > framework when all consumers are probed and there is no need to keep the > bandwidth set to maximum anymore. Should we add Fixes: tag? Thanks, Georgi > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/interconnect/qcom/sm8150.c | 1 + > drivers/interconnect/qcom/sm8250.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/interconnect/qcom/sm8150.c b/drivers/interconnect/qcom/sm8150.c > index 9218efed04a0..30fb6567fe19 100644 > --- a/drivers/interconnect/qcom/sm8150.c > +++ b/drivers/interconnect/qcom/sm8150.c > @@ -627,6 +627,7 @@ static struct platform_driver qnoc_driver = { > .driver = { > .name = "qnoc-sm8150", > .of_match_table = qnoc_of_match, > + .sync_state = icc_sync_state, > }, > }; > module_platform_driver(qnoc_driver); > diff --git a/drivers/interconnect/qcom/sm8250.c b/drivers/interconnect/qcom/sm8250.c > index 9b58946f7898..49c5ee2e70f0 100644 > --- a/drivers/interconnect/qcom/sm8250.c > +++ b/drivers/interconnect/qcom/sm8250.c > @@ -643,6 +643,7 @@ static struct platform_driver qnoc_driver = { > .driver = { > .name = "qnoc-sm8250", > .of_match_table = qnoc_of_match, > + .sync_state = icc_sync_state, > }, > }; > module_platform_driver(qnoc_driver); >
On 27/10/2020 14:24, Georgi Djakov wrote: > Hi Dmitry, > > Thanks for the patch! > > On 10/27/20 12:27, Dmitry Baryshkov wrote: >> In addition to the rest of Qcom interconnect drivers use icc_sync_state >> for SM8150/SM8250 interconnect drivers to notify the interconnect >> framework when all consumers are probed and there is no need to keep the >> bandwidth set to maximum anymore. > > Should we add Fixes: tag? Good question. I'd point Fixes: to sync_state commit. I'd add that to v2, also moving bcm registration. > > Thanks, > Georgi > >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> --- >> drivers/interconnect/qcom/sm8150.c | 1 + >> drivers/interconnect/qcom/sm8250.c | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/drivers/interconnect/qcom/sm8150.c b/drivers/interconnect/qcom/sm8150.c >> index 9218efed04a0..30fb6567fe19 100644 >> --- a/drivers/interconnect/qcom/sm8150.c >> +++ b/drivers/interconnect/qcom/sm8150.c >> @@ -627,6 +627,7 @@ static struct platform_driver qnoc_driver = { >> .driver = { >> .name = "qnoc-sm8150", >> .of_match_table = qnoc_of_match, >> + .sync_state = icc_sync_state, >> }, >> }; >> module_platform_driver(qnoc_driver); >> diff --git a/drivers/interconnect/qcom/sm8250.c b/drivers/interconnect/qcom/sm8250.c >> index 9b58946f7898..49c5ee2e70f0 100644 >> --- a/drivers/interconnect/qcom/sm8250.c >> +++ b/drivers/interconnect/qcom/sm8250.c >> @@ -643,6 +643,7 @@ static struct platform_driver qnoc_driver = { >> .driver = { >> .name = "qnoc-sm8250", >> .of_match_table = qnoc_of_match, >> + .sync_state = icc_sync_state, >> }, >> }; >> module_platform_driver(qnoc_driver); >>
diff --git a/drivers/interconnect/qcom/sm8150.c b/drivers/interconnect/qcom/sm8150.c index 9218efed04a0..30fb6567fe19 100644 --- a/drivers/interconnect/qcom/sm8150.c +++ b/drivers/interconnect/qcom/sm8150.c @@ -627,6 +627,7 @@ static struct platform_driver qnoc_driver = { .driver = { .name = "qnoc-sm8150", .of_match_table = qnoc_of_match, + .sync_state = icc_sync_state, }, }; module_platform_driver(qnoc_driver); diff --git a/drivers/interconnect/qcom/sm8250.c b/drivers/interconnect/qcom/sm8250.c index 9b58946f7898..49c5ee2e70f0 100644 --- a/drivers/interconnect/qcom/sm8250.c +++ b/drivers/interconnect/qcom/sm8250.c @@ -643,6 +643,7 @@ static struct platform_driver qnoc_driver = { .driver = { .name = "qnoc-sm8250", .of_match_table = qnoc_of_match, + .sync_state = icc_sync_state, }, }; module_platform_driver(qnoc_driver);
In addition to the rest of Qcom interconnect drivers use icc_sync_state for SM8150/SM8250 interconnect drivers to notify the interconnect framework when all consumers are probed and there is no need to keep the bandwidth set to maximum anymore. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/interconnect/qcom/sm8150.c | 1 + drivers/interconnect/qcom/sm8250.c | 1 + 2 files changed, 2 insertions(+)