| Message ID | 20210118011330.4145-4-digetx@gmail.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | GENPD API improvements | expand |
On 18-01-21, 04:13, Dmitry Osipenko wrote: > Driver of a power domain provider may not be ready at the time of > of_genpd_add_subdomain() invocation. Make this function to return > -EPROBE_DEFER instead of -ENOENT in order to remove a need from > power domain drivers to handle the error code specially. > > Suggested-by: Ulf Hansson <ulf.hansson@linaro.org> > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > drivers/base/power/domain.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index 2ab77aa516eb..7ef6764ee30f 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -2462,7 +2462,7 @@ int of_genpd_add_subdomain(struct of_phandle_args *parent_spec, > out: > mutex_unlock(&gpd_list_lock); > > - return ret; > + return ret == -ENOENT ? -EPROBE_DEFER : ret; > } > EXPORT_SYMBOL_GPL(of_genpd_add_subdomain); > Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
On Mon, 18 Jan 2021 at 02:13, Dmitry Osipenko <digetx@gmail.com> wrote: > > Driver of a power domain provider may not be ready at the time of > of_genpd_add_subdomain() invocation. Make this function to return > -EPROBE_DEFER instead of -ENOENT in order to remove a need from > power domain drivers to handle the error code specially. > > Suggested-by: Ulf Hansson <ulf.hansson@linaro.org> > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org> Kind regards Uffe > --- > drivers/base/power/domain.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index 2ab77aa516eb..7ef6764ee30f 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -2462,7 +2462,7 @@ int of_genpd_add_subdomain(struct of_phandle_args *parent_spec, > out: > mutex_unlock(&gpd_list_lock); > > - return ret; > + return ret == -ENOENT ? -EPROBE_DEFER : ret; > } > EXPORT_SYMBOL_GPL(of_genpd_add_subdomain); > > -- > 2.29.2 >
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 2ab77aa516eb..7ef6764ee30f 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -2462,7 +2462,7 @@ int of_genpd_add_subdomain(struct of_phandle_args *parent_spec, out: mutex_unlock(&gpd_list_lock); - return ret; + return ret == -ENOENT ? -EPROBE_DEFER : ret; } EXPORT_SYMBOL_GPL(of_genpd_add_subdomain);
Driver of a power domain provider may not be ready at the time of of_genpd_add_subdomain() invocation. Make this function to return -EPROBE_DEFER instead of -ENOENT in order to remove a need from power domain drivers to handle the error code specially. Suggested-by: Ulf Hansson <ulf.hansson@linaro.org> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/base/power/domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)