| Message ID | 20210223141122.9574-1-matthias.schiffer@ew.tq-group.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [1/3] power: supply: bq27xxx: fix sign of current_now for newer ICs | expand |
On Tue, 23 Feb 2021 15:11:20 +0100 Matthias Schiffer <matthias.schiffer@ew.tq-group.com> wrote: > Commit cd060b4d0868 ("power: supply: bq27xxx: fix polarity of current_now") > changed the sign of current_now for all bq27xxx variants, but on BQ28Z610 > I'm now seeing negated values *with* that patch. > > The GTA04/Openmoko device that was used for testing uses a BQ27000 or > BQ27010 IC, so I assume only the BQ27XXX_O_ZERO code path was incorrect. > Revert the behaviour for newer ICs. > > Fixes: cd060b4d0868 "power: supply: bq27xxx: fix polarity of current_now" > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> > --- > > @Andreas Kemnade: It would be great to get a confirmation that the > Openmoko battery indeed uses BQ27000/BQ27010 - I was having some trouble > finding that information. > I can confirm that. here is the corresponding schematic: http://people.openmoko.org/tony_tu/GTA02/hardware/GTA02/CT-GTA02.pdf Regards, Andreas
On Tuesday 23 February 2021 15:49:46 Andreas Kemnade wrote: > On Tue, 23 Feb 2021 15:11:20 +0100 > Matthias Schiffer <matthias.schiffer@ew.tq-group.com> wrote: > > > Commit cd060b4d0868 ("power: supply: bq27xxx: fix polarity of current_now") > > changed the sign of current_now for all bq27xxx variants, but on BQ28Z610 > > I'm now seeing negated values *with* that patch. > > > > The GTA04/Openmoko device that was used for testing uses a BQ27000 or > > BQ27010 IC, so I assume only the BQ27XXX_O_ZERO code path was incorrect. > > Revert the behaviour for newer ICs. > > > > Fixes: cd060b4d0868 "power: supply: bq27xxx: fix polarity of current_now" > > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> > > --- > > > > @Andreas Kemnade: It would be great to get a confirmation that the > > Openmoko battery indeed uses BQ27000/BQ27010 - I was having some trouble > > finding that information. > > > I can confirm that. > here is the corresponding schematic: > > http://people.openmoko.org/tony_tu/GTA02/hardware/GTA02/CT-GTA02.pdf > > Regards, > Andreas Nokia N900 has BQ27200 connected via i2c. CCing Maemo mailing list maemo-leste@lists.dyne.org
diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c index 4c4a7b1c64c5..cb6ebd2f905e 100644 --- a/drivers/power/supply/bq27xxx_battery.c +++ b/drivers/power/supply/bq27xxx_battery.c @@ -1827,7 +1827,7 @@ static int bq27xxx_battery_current(struct bq27xxx_device_info *di, val->intval = curr * BQ27XXX_CURRENT_CONSTANT / BQ27XXX_RS; } else { /* Other gauges return signed value */ - val->intval = -(int)((s16)curr) * 1000; + val->intval = (int)((s16)curr) * 1000; } return 0;
Commit cd060b4d0868 ("power: supply: bq27xxx: fix polarity of current_now") changed the sign of current_now for all bq27xxx variants, but on BQ28Z610 I'm now seeing negated values *with* that patch. The GTA04/Openmoko device that was used for testing uses a BQ27000 or BQ27010 IC, so I assume only the BQ27XXX_O_ZERO code path was incorrect. Revert the behaviour for newer ICs. Fixes: cd060b4d0868 "power: supply: bq27xxx: fix polarity of current_now" Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> --- @Andreas Kemnade: It would be great to get a confirmation that the Openmoko battery indeed uses BQ27000/BQ27010 - I was having some trouble finding that information. drivers/power/supply/bq27xxx_battery.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)