diff mbox series

[2/2] thermal: sprd: add missing of_node_put for loop iteration

Message ID 20210425174831.164332-2-krzysztof.kozlowski@canonical.com (mailing list archive)
State New
Delegated to: Daniel Lezcano
Headers show
Series [1/2] thermal: imx_sc: add missing of_node_put for loop iteration | expand

Commit Message

Krzysztof Kozlowski April 25, 2021, 5:48 p.m. UTC
Early exits from for_each_available_child_of_node() should decrement the
node reference counter.  Reported by Coccinelle:

  drivers/thermal/sprd_thermal.c:387:1-23: WARNING:
    Function "for_each_child_of_node" should have of_node_put() before goto around lines 391.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 drivers/thermal/sprd_thermal.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Chunyan Zhang April 26, 2021, 8:07 a.m. UTC | #1
On Mon, 26 Apr 2021 at 01:48, Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> Early exits from for_each_available_child_of_node() should decrement the
> node reference counter.  Reported by Coccinelle:
>
>   drivers/thermal/sprd_thermal.c:387:1-23: WARNING:
>     Function "for_each_child_of_node" should have of_node_put() before goto around lines 391.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

Acked-by: Chunyan Zhang <zhang.lyra@gmail.com>

Thanks for fixing this.

> ---
>  drivers/thermal/sprd_thermal.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/thermal/sprd_thermal.c b/drivers/thermal/sprd_thermal.c
> index 3682edb2f466..2778971aaf03 100644
> --- a/drivers/thermal/sprd_thermal.c
> +++ b/drivers/thermal/sprd_thermal.c
> @@ -388,6 +388,7 @@ static int sprd_thm_probe(struct platform_device *pdev)
>                 sen = devm_kzalloc(&pdev->dev, sizeof(*sen), GFP_KERNEL);
>                 if (!sen) {
>                         ret = -ENOMEM;
> +                       of_node_put(sen_child);
>                         goto disable_clk;
>                 }
>
> @@ -397,12 +398,14 @@ static int sprd_thm_probe(struct platform_device *pdev)
>                 ret = of_property_read_u32(sen_child, "reg", &sen->id);
>                 if (ret) {
>                         dev_err(&pdev->dev, "get sensor reg failed");
> +                       of_node_put(sen_child);
>                         goto disable_clk;
>                 }
>
>                 ret = sprd_thm_sensor_calibration(sen_child, thm, sen);
>                 if (ret) {
>                         dev_err(&pdev->dev, "efuse cal analysis failed");
> +                       of_node_put(sen_child);
>                         goto disable_clk;
>                 }
>
> @@ -416,6 +419,7 @@ static int sprd_thm_probe(struct platform_device *pdev)
>                         dev_err(&pdev->dev, "register thermal zone failed %d\n",
>                                 sen->id);
>                         ret = PTR_ERR(sen->tzd);
> +                       of_node_put(sen_child);
>                         goto disable_clk;
>                 }
>
> --
> 2.25.1
>
diff mbox series

Patch

diff --git a/drivers/thermal/sprd_thermal.c b/drivers/thermal/sprd_thermal.c
index 3682edb2f466..2778971aaf03 100644
--- a/drivers/thermal/sprd_thermal.c
+++ b/drivers/thermal/sprd_thermal.c
@@ -388,6 +388,7 @@  static int sprd_thm_probe(struct platform_device *pdev)
 		sen = devm_kzalloc(&pdev->dev, sizeof(*sen), GFP_KERNEL);
 		if (!sen) {
 			ret = -ENOMEM;
+			of_node_put(sen_child);
 			goto disable_clk;
 		}
 
@@ -397,12 +398,14 @@  static int sprd_thm_probe(struct platform_device *pdev)
 		ret = of_property_read_u32(sen_child, "reg", &sen->id);
 		if (ret) {
 			dev_err(&pdev->dev, "get sensor reg failed");
+			of_node_put(sen_child);
 			goto disable_clk;
 		}
 
 		ret = sprd_thm_sensor_calibration(sen_child, thm, sen);
 		if (ret) {
 			dev_err(&pdev->dev, "efuse cal analysis failed");
+			of_node_put(sen_child);
 			goto disable_clk;
 		}
 
@@ -416,6 +419,7 @@  static int sprd_thm_probe(struct platform_device *pdev)
 			dev_err(&pdev->dev, "register thermal zone failed %d\n",
 				sen->id);
 			ret = PTR_ERR(sen->tzd);
+			of_node_put(sen_child);
 			goto disable_clk;
 		}