diff mbox series

[1/2] PM / devfreq: imx-bus: Remove imx_bus_get_dev_status

Message ID 20210519070545.1728197-1-aisheng.dong@nxp.com (mailing list archive)
State New
Delegated to: Chanwoo Choi
Headers show
Series [1/2] PM / devfreq: imx-bus: Remove imx_bus_get_dev_status | expand

Commit Message

Aisheng Dong May 19, 2021, 7:05 a.m. UTC
Current driver actually does not support simple ondemand governor
as it's unable to provide device load information. So removing
the unnecessary callback to avoid confusing.
Right now the driver is using userspace governor by default.

polling_ms was also dropped as it's not needed for non-ondemand
governor.

Cc: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
 drivers/devfreq/imx-bus.c | 14 --------------
 1 file changed, 14 deletions(-)

Comments

Chanwoo Choi May 20, 2021, 2:51 a.m. UTC | #1
On 5/19/21 4:05 PM, Dong Aisheng wrote:
> Current driver actually does not support simple ondemand governor
> as it's unable to provide device load information. So removing
> the unnecessary callback to avoid confusing.
> Right now the driver is using userspace governor by default.
> 
> polling_ms was also dropped as it's not needed for non-ondemand
> governor.
> 
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
>  drivers/devfreq/imx-bus.c | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/drivers/devfreq/imx-bus.c b/drivers/devfreq/imx-bus.c
> index 3fc3fd77492d..f3f6e25053ed 100644
> --- a/drivers/devfreq/imx-bus.c
> +++ b/drivers/devfreq/imx-bus.c
> @@ -45,18 +45,6 @@ static int imx_bus_get_cur_freq(struct device *dev, unsigned long *freq)
>  	return 0;
>  }
>  
> -static int imx_bus_get_dev_status(struct device *dev,
> -		struct devfreq_dev_status *stat)
> -{
> -	struct imx_bus *priv = dev_get_drvdata(dev);
> -
> -	stat->busy_time = 0;
> -	stat->total_time = 0;
> -	stat->current_frequency = clk_get_rate(priv->clk);
> -
> -	return 0;
> -}
> -
>  static void imx_bus_exit(struct device *dev)
>  {
>  	struct imx_bus *priv = dev_get_drvdata(dev);
> @@ -129,9 +117,7 @@ static int imx_bus_probe(struct platform_device *pdev)
>  		return ret;
>  	}
>  
> -	priv->profile.polling_ms = 1000;
>  	priv->profile.target = imx_bus_target;
> -	priv->profile.get_dev_status = imx_bus_get_dev_status;
>  	priv->profile.exit = imx_bus_exit;
>  	priv->profile.get_cur_freq = imx_bus_get_cur_freq;
>  	priv->profile.initial_freq = clk_get_rate(priv->clk);
> 

Applied it. Thanks.
diff mbox series

Patch

diff --git a/drivers/devfreq/imx-bus.c b/drivers/devfreq/imx-bus.c
index 3fc3fd77492d..f3f6e25053ed 100644
--- a/drivers/devfreq/imx-bus.c
+++ b/drivers/devfreq/imx-bus.c
@@ -45,18 +45,6 @@  static int imx_bus_get_cur_freq(struct device *dev, unsigned long *freq)
 	return 0;
 }
 
-static int imx_bus_get_dev_status(struct device *dev,
-		struct devfreq_dev_status *stat)
-{
-	struct imx_bus *priv = dev_get_drvdata(dev);
-
-	stat->busy_time = 0;
-	stat->total_time = 0;
-	stat->current_frequency = clk_get_rate(priv->clk);
-
-	return 0;
-}
-
 static void imx_bus_exit(struct device *dev)
 {
 	struct imx_bus *priv = dev_get_drvdata(dev);
@@ -129,9 +117,7 @@  static int imx_bus_probe(struct platform_device *pdev)
 		return ret;
 	}
 
-	priv->profile.polling_ms = 1000;
 	priv->profile.target = imx_bus_target;
-	priv->profile.get_dev_status = imx_bus_get_dev_status;
 	priv->profile.exit = imx_bus_exit;
 	priv->profile.get_cur_freq = imx_bus_get_cur_freq;
 	priv->profile.initial_freq = clk_get_rate(priv->clk);