diff mbox series

[2/2] devfreq: imx8m-ddrc: de-select DEVFREQ_GOV_SIMPLE_ONDEMAND

Message ID 20210519070545.1728197-2-aisheng.dong@nxp.com (mailing list archive)
State New
Delegated to: Chanwoo Choi
Headers show
Series [1/2] PM / devfreq: imx-bus: Remove imx_bus_get_dev_status | expand

Commit Message

Aisheng Dong May 19, 2021, 7:05 a.m. UTC
The driver can't support simple ondemand governor due to missing
.get_dev_status() capability.

Cc: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
 drivers/devfreq/Kconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Chanwoo Choi May 20, 2021, 3:10 a.m. UTC | #1
On 5/19/21 4:05 PM, Dong Aisheng wrote:
> The driver can't support simple ondemand governor due to missing
> .get_dev_status() capability.
> 
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
>  drivers/devfreq/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> index 20373a893b44..e87d01c0b76a 100644
> --- a/drivers/devfreq/Kconfig
> +++ b/drivers/devfreq/Kconfig
> @@ -103,7 +103,6 @@ config ARM_IMX8M_DDRC_DEVFREQ
>  	tristate "i.MX8M DDRC DEVFREQ Driver"
>  	depends on (ARCH_MXC && HAVE_ARM_SMCCC) || \
>  		(COMPILE_TEST && HAVE_ARM_SMCCC)
> -	select DEVFREQ_GOV_SIMPLE_ONDEMAND
>  	select DEVFREQ_GOV_USERSPACE
>  	help
>  	  This adds the DEVFREQ driver for the i.MX8M DDR Controller. It allows
> 

Looks good to me. But, How about changing the patch title as following?
- PM / devfreq: imx8m-ddrc: Remove DEVFREQ_GOV_SIMPLE_ONDEMAND dependency
Aisheng Dong May 21, 2021, 3:04 a.m. UTC | #2
> From: Chanwoo Choi <cw00.choi@samsung.com>
> Sent: Thursday, May 20, 2021 11:10 AM
> 
> On 5/19/21 4:05 PM, Dong Aisheng wrote:
> > The driver can't support simple ondemand governor due to missing
> > .get_dev_status() capability.
> >
> > Cc: Chanwoo Choi <cw00.choi@samsung.com>
> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > ---
> >  drivers/devfreq/Kconfig | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig index
> > 20373a893b44..e87d01c0b76a 100644
> > --- a/drivers/devfreq/Kconfig
> > +++ b/drivers/devfreq/Kconfig
> > @@ -103,7 +103,6 @@ config ARM_IMX8M_DDRC_DEVFREQ
> >  	tristate "i.MX8M DDRC DEVFREQ Driver"
> >  	depends on (ARCH_MXC && HAVE_ARM_SMCCC) || \
> >  		(COMPILE_TEST && HAVE_ARM_SMCCC)
> > -	select DEVFREQ_GOV_SIMPLE_ONDEMAND
> >  	select DEVFREQ_GOV_USERSPACE
> >  	help
> >  	  This adds the DEVFREQ driver for the i.MX8M DDR Controller. It
> > allows
> >
> 
> Looks good to me. But, How about changing the patch title as following?
> - PM / devfreq: imx8m-ddrc: Remove DEVFREQ_GOV_SIMPLE_ONDEMAND
> dependency

Yes, good suggestion. Thanks
I will resend v2.

Regards
Aisheng

> 
> 
> --
> Best Regards,
> Chanwoo Choi
> Samsung Electronics
diff mbox series

Patch

diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
index 20373a893b44..e87d01c0b76a 100644
--- a/drivers/devfreq/Kconfig
+++ b/drivers/devfreq/Kconfig
@@ -103,7 +103,6 @@  config ARM_IMX8M_DDRC_DEVFREQ
 	tristate "i.MX8M DDRC DEVFREQ Driver"
 	depends on (ARCH_MXC && HAVE_ARM_SMCCC) || \
 		(COMPILE_TEST && HAVE_ARM_SMCCC)
-	select DEVFREQ_GOV_SIMPLE_ONDEMAND
 	select DEVFREQ_GOV_USERSPACE
 	help
 	  This adds the DEVFREQ driver for the i.MX8M DDR Controller. It allows