diff mbox series

[v2,1/3] PM: runtime: Improve path in rpm_idle() when no callback

Message ID 20210608090250.85256-2-ulf.hansson@linaro.org (mailing list archive)
State Queued
Delegated to: Rafael Wysocki
Headers show
Series PM: runtime: Update behaviour for no callbacks | expand

Commit Message

Ulf Hansson June 8, 2021, 9:02 a.m. UTC
When pm_runtime_no_callbacks() has been called for a struct device to set
the dev->power.no_callbacks flag for it, it enables rpm_idle() to take a
slightly quicker path by assuming that a ->runtime_idle() callback would
have returned 0 to indicate success.

A device that does not have the dev->power.no_callbacks flag set for it,
may still be missing a corresponding ->runtime_idle() callback, in which
case the slower path in rpm_idle() is taken. Let's improve the behaviour
for this case, by aligning code to the quicker path.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

Changes in v2:
	- None.

 drivers/base/power/runtime.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
diff mbox series


diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c
index b570848d23e0..68bebbf81347 100644
--- a/drivers/base/power/runtime.c
+++ b/drivers/base/power/runtime.c
@@ -446,7 +446,10 @@  static int rpm_idle(struct device *dev, int rpmflags)
 	/* Pending requests need to be canceled. */
 	dev->power.request = RPM_REQ_NONE;
-	if (dev->power.no_callbacks)
+	callback = RPM_GET_CALLBACK(dev, runtime_idle);
+	/* If no callback assume success. */
+	if (!callback || dev->power.no_callbacks)
 		goto out;
 	/* Carry out an asynchronous or a synchronous idle notification. */
@@ -462,10 +465,7 @@  static int rpm_idle(struct device *dev, int rpmflags)
 	dev->power.idle_notification = true;
-	callback = RPM_GET_CALLBACK(dev, runtime_idle);
-	if (callback)
-		retval = __rpm_callback(callback, dev);
+	retval = __rpm_callback(callback, dev);
 	dev->power.idle_notification = false;