diff mbox series

[next] opp: remove redundant continue statement

Message ID 20210617135020.16415-1-colin.king@canonical.com (mailing list archive)
State New
Delegated to: viresh kumar
Headers show
Series [next] opp: remove redundant continue statement | expand

Commit Message

Colin King June 17, 2021, 1:50 p.m. UTC
From: Colin Ian King <colin.king@canonical.com>

The continue statement at the end of a for-loop has no effect,
remove it.

Addresses-Coverity: ("Continue has no effect")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/opp/of.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Viresh Kumar June 18, 2021, 3:32 a.m. UTC | #1
On 17-06-21, 14:50, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The continue statement at the end of a for-loop has no effect,
> remove it.
> 
> Addresses-Coverity: ("Continue has no effect")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/opp/of.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/opp/of.c b/drivers/opp/of.c
> index 9573facce53a..d298e38aaf7e 100644
> --- a/drivers/opp/of.c
> +++ b/drivers/opp/of.c
> @@ -197,10 +197,8 @@ static void _opp_table_alloc_required_tables(struct opp_table *opp_table,
>  		required_opp_tables[i] = _find_table_of_opp_np(required_np);
>  		of_node_put(required_np);
>  
> -		if (IS_ERR(required_opp_tables[i])) {
> +		if (IS_ERR(required_opp_tables[i]))
>  			lazy = true;
> -			continue;
> -		}
>  	}

I had to merge this with:

"opp: Allow required-opps to be used for non genpd use cases"

Thanks for the report anyway :)
diff mbox series

Patch

diff --git a/drivers/opp/of.c b/drivers/opp/of.c
index 9573facce53a..d298e38aaf7e 100644
--- a/drivers/opp/of.c
+++ b/drivers/opp/of.c
@@ -197,10 +197,8 @@  static void _opp_table_alloc_required_tables(struct opp_table *opp_table,
 		required_opp_tables[i] = _find_table_of_opp_np(required_np);
 		of_node_put(required_np);
 
-		if (IS_ERR(required_opp_tables[i])) {
+		if (IS_ERR(required_opp_tables[i]))
 			lazy = true;
-			continue;
-		}
 	}
 
 	/* Let's do the linking later on */