| Message ID | 20210930100928.2211599-1-claudiu.beznea@microchip.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | power: reset: at91-reset: check properly the return value of devm_of_iomap | expand |
Hi, On Thu, Sep 30, 2021 at 01:09:28PM +0300, Claudiu Beznea wrote: > devm_of_iomap() returns error code or valid pointer. Check its return > value with IS_ERR(). > > Fixes: bd3127733f2c ("power: reset: at91-reset: use devm_of_iomap") > Reported-by: Cristian Birsan <cristian.birsan@microchip.com> > Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> > --- Thanks, queued. -- Sebastian > drivers/power/reset/at91-reset.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/power/reset/at91-reset.c b/drivers/power/reset/at91-reset.c > index 026649409135..64def79d557a 100644 > --- a/drivers/power/reset/at91-reset.c > +++ b/drivers/power/reset/at91-reset.c > @@ -193,7 +193,7 @@ static int __init at91_reset_probe(struct platform_device *pdev) > return -ENOMEM; > > reset->rstc_base = devm_of_iomap(&pdev->dev, pdev->dev.of_node, 0, NULL); > - if (!reset->rstc_base) { > + if (IS_ERR(reset->rstc_base)) { > dev_err(&pdev->dev, "Could not map reset controller address\n"); > return -ENODEV; > } > @@ -203,7 +203,7 @@ static int __init at91_reset_probe(struct platform_device *pdev) > for_each_matching_node_and_match(np, at91_ramc_of_match, &match) { > reset->ramc_lpr = (u32)match->data; > reset->ramc_base[idx] = devm_of_iomap(&pdev->dev, np, 0, NULL); > - if (!reset->ramc_base[idx]) { > + if (IS_ERR(reset->ramc_base[idx])) { > dev_err(&pdev->dev, "Could not map ram controller address\n"); > of_node_put(np); > return -ENODEV; > -- > 2.25.1 >
diff --git a/drivers/power/reset/at91-reset.c b/drivers/power/reset/at91-reset.c index 026649409135..64def79d557a 100644 --- a/drivers/power/reset/at91-reset.c +++ b/drivers/power/reset/at91-reset.c @@ -193,7 +193,7 @@ static int __init at91_reset_probe(struct platform_device *pdev) return -ENOMEM; reset->rstc_base = devm_of_iomap(&pdev->dev, pdev->dev.of_node, 0, NULL); - if (!reset->rstc_base) { + if (IS_ERR(reset->rstc_base)) { dev_err(&pdev->dev, "Could not map reset controller address\n"); return -ENODEV; } @@ -203,7 +203,7 @@ static int __init at91_reset_probe(struct platform_device *pdev) for_each_matching_node_and_match(np, at91_ramc_of_match, &match) { reset->ramc_lpr = (u32)match->data; reset->ramc_base[idx] = devm_of_iomap(&pdev->dev, np, 0, NULL); - if (!reset->ramc_base[idx]) { + if (IS_ERR(reset->ramc_base[idx])) { dev_err(&pdev->dev, "Could not map ram controller address\n"); of_node_put(np); return -ENODEV;
devm_of_iomap() returns error code or valid pointer. Check its return value with IS_ERR(). Fixes: bd3127733f2c ("power: reset: at91-reset: use devm_of_iomap") Reported-by: Cristian Birsan <cristian.birsan@microchip.com> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> --- drivers/power/reset/at91-reset.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)