| Message ID | 20211008083245.2884-1-jahau@rocketmail.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | power: supply: rt5033_battery: Change voltage values to µV | expand |
Hi, On Fri, Oct 08, 2021 at 10:32:45AM +0200, Jakob Hauser wrote: > Currently the rt5033_battery driver provides voltage values in mV. It > should be µV as stated in Documentation/power/power_supply_class.rst. > > Fixes: b847dd96e659 ("power: rt5033_battery: Add RT5033 Fuel gauge device driver") > Cc: Beomho Seo <beomho.seo@samsung.com> > Cc: Chanwoo Choi <cw00.choi@samsung.com> > Signed-off-by: Jakob Hauser <jahau@rocketmail.com> > --- > drivers/power/supply/rt5033_battery.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/supply/rt5033_battery.c b/drivers/power/supply/rt5033_battery.c > index 9ad0afe83d1b..7a23c70f4879 100644 > --- a/drivers/power/supply/rt5033_battery.c > +++ b/drivers/power/supply/rt5033_battery.c > @@ -60,7 +60,7 @@ static int rt5033_battery_get_watt_prop(struct i2c_client *client, > regmap_read(battery->regmap, regh, &msb); > regmap_read(battery->regmap, regl, &lsb); > > - ret = ((msb << 4) + (lsb >> 4)) * 1250 / 1000; > + ret = ((msb << 4) + (lsb >> 4)) * 1250; > > return ret; > } Thanks, queued. -- Sebastian
diff --git a/drivers/power/supply/rt5033_battery.c b/drivers/power/supply/rt5033_battery.c index 9ad0afe83d1b..7a23c70f4879 100644 --- a/drivers/power/supply/rt5033_battery.c +++ b/drivers/power/supply/rt5033_battery.c @@ -60,7 +60,7 @@ static int rt5033_battery_get_watt_prop(struct i2c_client *client, regmap_read(battery->regmap, regh, &msb); regmap_read(battery->regmap, regl, &lsb); - ret = ((msb << 4) + (lsb >> 4)) * 1250 / 1000; + ret = ((msb << 4) + (lsb >> 4)) * 1250; return ret; }
Currently the rt5033_battery driver provides voltage values in mV. It should be µV as stated in Documentation/power/power_supply_class.rst. Fixes: b847dd96e659 ("power: rt5033_battery: Add RT5033 Fuel gauge device driver") Cc: Beomho Seo <beomho.seo@samsung.com> Cc: Chanwoo Choi <cw00.choi@samsung.com> Signed-off-by: Jakob Hauser <jahau@rocketmail.com> --- drivers/power/supply/rt5033_battery.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)