diff mbox series

[RFC,2/3] dt-bindings: power: reset: syscon-reboot: add "reg" property

Message ID 20211102152207.11891-3-zajec5@gmail.com (mailing list archive)
State Not Applicable, archived
Headers show
Series reset: syscon-reboot: add "reg" property support | expand

Commit Message

Rafał Miłecki Nov. 2, 2021, 3:22 p.m. UTC
From: Rafał Miłecki <rafal@milecki.pl>

Reboot node should be a child of mfd/syscon node and should use "reg"
property to specify regmap offset.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 .../bindings/power/reset/syscon-reboot.yaml        | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

Comments

Rob Herring (Arm) Nov. 12, 2021, 7:34 p.m. UTC | #1
On Tue, 02 Nov 2021 16:22:06 +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> Reboot node should be a child of mfd/syscon node and should use "reg"
> property to specify regmap offset.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
>  .../bindings/power/reset/syscon-reboot.yaml        | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
index ebae55683d39..ddcf6e5dcdfa 100644
--- a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
+++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
@@ -31,6 +31,10 @@  properties:
     $ref: /schemas/types.yaml#/definitions/uint32
     description: Offset in the register map for the reboot register (in bytes).
 
+  reg:
+    maxItems: 1
+    description: Offset in the register map and size (must be 4 B)
+
   regmap:
     $ref: /schemas/types.yaml#/definitions/phandle
     deprecated: true
@@ -42,12 +46,14 @@  properties:
     $ref: /schemas/types.yaml#/definitions/uint32
     description: The reset value written to the reboot register (32 bit access).
 
-required:
-  - compatible
-  - offset
-
 additionalProperties: false
 
+anyOf:
+  - required:
+      - reg
+  - required:
+      - offset
+
 allOf:
   - if:
       not: