| Message ID | 20220209001546.18189-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Headers | show |
| Series | [-next] thermal: intel: INTEL_HFI_THERMAL depends on NET | expand |
On Tue, 2022-02-08 at 16:15 -0800, Randy Dunlap wrote: > THERMAL_NETLINK depends on NET and since 'select' does not follow > any dependency chain, INTEL_HFI_THERMAL also should depend on NET. > > Fix one Kconfig warning and 48 subsequent build errors: > > WARNING: unmet direct dependencies detected for THERMAL_NETLINK > Depends on [n]: THERMAL [=y] && NET [=n] > Selected by [y]: > - INTEL_HFI_THERMAL [=y] && THERMAL [=y] && (X86 [=y] || > X86_INTEL_QUARK [=n] || COMPILE_TEST [=y]) && CPU_SUP_INTEL [=y] && > X86_THERMAL_VECTOR [=y] > Thanks for the fix. > Fixes: bd30cdfd9bd7 ("thermal: intel: hfi: Notify user space for HFI > events") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > Cc: Aubrey Li <aubrey.li@linux.intel.com> > Cc: Ricardo Neri <ricardo.neri-calderon@linux.intel.com> > Cc: Rafael J. Wysocki <rafael@kernel.org> > Cc: Daniel Lezcano <daniel.lezcano@linaro.org> > Cc: Amit Kucheria <amitk@kernel.org> > Cc: Zhang Rui <rui.zhang@intel.com> > Cc: linux-pm@vger.kernel.org > Cc: Andrew Morton <akpm@linux-foundation.org> Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > --- > Found in mmotm, linux-next.patch. > > drivers/thermal/intel/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- mmotm-2022-0208-1531.orig/drivers/thermal/intel/Kconfig > +++ mmotm-2022-0208-1531/drivers/thermal/intel/Kconfig > @@ -102,6 +102,7 @@ config INTEL_MENLOW > > config INTEL_HFI_THERMAL > bool "Intel Hardware Feedback Interface" > + depends on NET > depends on CPU_SUP_INTEL > depends on X86_THERMAL_VECTOR > select THERMAL_NETLINK
--- mmotm-2022-0208-1531.orig/drivers/thermal/intel/Kconfig +++ mmotm-2022-0208-1531/drivers/thermal/intel/Kconfig @@ -102,6 +102,7 @@ config INTEL_MENLOW config INTEL_HFI_THERMAL bool "Intel Hardware Feedback Interface" + depends on NET depends on CPU_SUP_INTEL depends on X86_THERMAL_VECTOR select THERMAL_NETLINK
THERMAL_NETLINK depends on NET and since 'select' does not follow any dependency chain, INTEL_HFI_THERMAL also should depend on NET. Fix one Kconfig warning and 48 subsequent build errors: WARNING: unmet direct dependencies detected for THERMAL_NETLINK Depends on [n]: THERMAL [=y] && NET [=n] Selected by [y]: - INTEL_HFI_THERMAL [=y] && THERMAL [=y] && (X86 [=y] || X86_INTEL_QUARK [=n] || COMPILE_TEST [=y]) && CPU_SUP_INTEL [=y] && X86_THERMAL_VECTOR [=y] Fixes: bd30cdfd9bd7 ("thermal: intel: hfi: Notify user space for HFI events") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Cc: Aubrey Li <aubrey.li@linux.intel.com> Cc: Ricardo Neri <ricardo.neri-calderon@linux.intel.com> Cc: Rafael J. Wysocki <rafael@kernel.org> Cc: Daniel Lezcano <daniel.lezcano@linaro.org> Cc: Amit Kucheria <amitk@kernel.org> Cc: Zhang Rui <rui.zhang@intel.com> Cc: linux-pm@vger.kernel.org Cc: Andrew Morton <akpm@linux-foundation.org> --- Found in mmotm, linux-next.patch. drivers/thermal/intel/Kconfig | 1 + 1 file changed, 1 insertion(+)