| Message ID | 20220524123151.1416-1-tangbin@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | viresh kumar |
| Headers | show |
| Series | opp: Fix error check in dev_pm_opp_attach_genpd() | expand |
On 24-05-22, 20:31, Tang Bin wrote: > dev_pm_domain_attach_by_name() may return NULL in some cases, > so IS_ERR() doesn't meet the requirements. Thus fix it. > > Fixes: 6319aee10e53 ("opp: Attach genpds to devices from within OPP core") > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> > --- > drivers/opp/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/opp/core.c b/drivers/opp/core.c > index 2945f3c1c..56cae6ee2 100644 > --- a/drivers/opp/core.c > +++ b/drivers/opp/core.c > @@ -2409,8 +2409,8 @@ struct opp_table *dev_pm_opp_attach_genpd(struct device *dev, > } > > virt_dev = dev_pm_domain_attach_by_name(dev, *name); > - if (IS_ERR(virt_dev)) { > - ret = PTR_ERR(virt_dev); > + if (IS_ERR_OR_NULL(virt_dev)) { > + ret = PTR_ERR(virt_dev) ? : -ENODATA; I have changed this to ENODEV instead. > dev_err(dev, "Couldn't attach to pm_domain: %d\n", ret); > goto err; > } Applied. Thanks.
diff --git a/drivers/opp/core.c b/drivers/opp/core.c index 2945f3c1c..56cae6ee2 100644 --- a/drivers/opp/core.c +++ b/drivers/opp/core.c @@ -2409,8 +2409,8 @@ struct opp_table *dev_pm_opp_attach_genpd(struct device *dev, } virt_dev = dev_pm_domain_attach_by_name(dev, *name); - if (IS_ERR(virt_dev)) { - ret = PTR_ERR(virt_dev); + if (IS_ERR_OR_NULL(virt_dev)) { + ret = PTR_ERR(virt_dev) ? : -ENODATA; dev_err(dev, "Couldn't attach to pm_domain: %d\n", ret); goto err; }
dev_pm_domain_attach_by_name() may return NULL in some cases, so IS_ERR() doesn't meet the requirements. Thus fix it. Fixes: 6319aee10e53 ("opp: Attach genpds to devices from within OPP core") Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> --- drivers/opp/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)