| Message ID | 20220701023328.2783-5-mario.limonciello@amd.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [v3,01/10] PM: suspend: Introduce `pm_suspend_preferred_s2idle` | expand |
Hi Mario,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on drm-misc/drm-misc-next hid/for-next linus/master v5.19-rc4 next-20220701]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello/PM-suspend-Introduce-pm_suspend_preferred_s2idle/20220701-103534
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: i386-randconfig-a001 (https://download.01.org/0day-ci/archive/20220701/202207011940.s0fsRy23-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/f5c9ad12802ecfaf2fc73e35ee9b563d7283b049
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Mario-Limonciello/PM-suspend-Introduce-pm_suspend_preferred_s2idle/20220701-103534
git checkout f5c9ad12802ecfaf2fc73e35ee9b563d7283b049
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/rtc/rtc-cmos.c: In function 'use_acpi_alarm_quirks':
>> drivers/rtc/rtc-cmos.c:1264:14: error: implicit declaration of function 'pm_suspend_preferred_s2idle'; did you mean 'pm_suspend_default_s2idle'? [-Werror=implicit-function-declaration]
1264 | if (!pm_suspend_preferred_s2idle())
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
| pm_suspend_default_s2idle
cc1: some warnings being treated as errors
vim +1264 drivers/rtc/rtc-cmos.c
1256
1257 #ifdef CONFIG_X86
1258 /* Enable use_acpi_alarm mode for Intel platforms no earlier than 2015 */
1259 static void use_acpi_alarm_quirks(void)
1260 {
1261 if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL)
1262 return;
1263
> 1264 if (!pm_suspend_preferred_s2idle())
1265 return;
1266
1267 if (!is_hpet_enabled())
1268 return;
1269
1270 if (dmi_get_bios_year() < 2015)
1271 return;
1272
1273 use_acpi_alarm = true;
1274 }
1275 #else
1276 static inline void use_acpi_alarm_quirks(void) { }
1277 #endif
1278
diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c index 7c006c2b125f..2e3d35e87061 100644 --- a/drivers/rtc/rtc-cmos.c +++ b/drivers/rtc/rtc-cmos.c @@ -32,6 +32,7 @@ #include <linux/init.h> #include <linux/interrupt.h> #include <linux/spinlock.h> +#include <linux/suspend.h> #include <linux/platform_device.h> #include <linux/log2.h> #include <linux/pm.h> @@ -1260,7 +1261,7 @@ static void use_acpi_alarm_quirks(void) if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL) return; - if (!(acpi_gbl_FADT.flags & ACPI_FADT_LOW_POWER_S0)) + if (!pm_suspend_preferred_s2idle()) return; if (!is_hpet_enabled())
Drop the direct check from the FADT and use the helper instead. Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> --- drivers/rtc/rtc-cmos.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)