| Message ID | 20220715210911.714479-2-daniel.lezcano@linaro.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [v3,1/4] thermal/core: Encapsulate the trip point crossed function | expand |
On Fri, 2022-07-15 at 23:09 +0200, Daniel Lezcano wrote: > As the trip temperature is already available when calling the > function > handle_critical_trips(), pass it as a parameter instead of having > this > function calling the ops again to retrieve the same data. > > Reviewed-by: Lukasz Luba <lukasz.luba@arm.com> > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > --- > v3: > - Massaged the patch title and the description > --- > drivers/thermal/thermal_core.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/thermal/thermal_core.c > b/drivers/thermal/thermal_core.c > index d9f771b15ed8..f66036b3daae 100644 > --- a/drivers/thermal/thermal_core.c > +++ b/drivers/thermal/thermal_core.c > @@ -340,12 +340,8 @@ void thermal_zone_device_critical(struct > thermal_zone_device *tz) > EXPORT_SYMBOL(thermal_zone_device_critical); > > static void handle_critical_trips(struct thermal_zone_device *tz, > - int trip, enum thermal_trip_type > trip_type) > + int trip, int trip_temp, enum > thermal_trip_type trip_type) This indent cleanup belongs to patch 1/4. Other than that, Reviewed-by: Zhang Rui <rui.zhang@intel.com> > { > - int trip_temp; > - > - tz->ops->get_trip_temp(tz, trip, &trip_temp); > - > /* If we have not crossed the trip_temp, we do not care. */ > if (trip_temp <= 0 || tz->temperature < trip_temp) > return; > @@ -394,7 +390,7 @@ static void handle_thermal_trip(struct > thermal_zone_device *tz, int trip) > handle_thermal_trip_crossed(tz, trip, trip_temp, hyst, type); > > if (type == THERMAL_TRIP_CRITICAL || type == > THERMAL_TRIP_HOT) > - handle_critical_trips(tz, trip, type); > + handle_critical_trips(tz, trip, trip_temp, type); > else > handle_non_critical_trips(tz, trip); > /*
On 18/07/2022 06:59, Zhang Rui wrote: > On Fri, 2022-07-15 at 23:09 +0200, Daniel Lezcano wrote: >> As the trip temperature is already available when calling the >> function >> handle_critical_trips(), pass it as a parameter instead of having >> this >> function calling the ops again to retrieve the same data. >> >> Reviewed-by: Lukasz Luba <lukasz.luba@arm.com> >> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> >> --- >> v3: >> - Massaged the patch title and the description >> --- >> drivers/thermal/thermal_core.c | 8 ++------ >> 1 file changed, 2 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/thermal/thermal_core.c >> b/drivers/thermal/thermal_core.c >> index d9f771b15ed8..f66036b3daae 100644 >> --- a/drivers/thermal/thermal_core.c >> +++ b/drivers/thermal/thermal_core.c >> @@ -340,12 +340,8 @@ void thermal_zone_device_critical(struct >> thermal_zone_device *tz) >> EXPORT_SYMBOL(thermal_zone_device_critical); >> >> static void handle_critical_trips(struct thermal_zone_device *tz, >> - int trip, enum thermal_trip_type >> trip_type) >> + int trip, int trip_temp, enum >> thermal_trip_type trip_type) > > This indent cleanup belongs to patch 1/4. It is not an indent cleanup, the 'int trip_temp' is added in the parameters. > Other than that, > > Reviewed-by: Zhang Rui <rui.zhang@intel.com> [ ... ]
On Mon, 2022-07-18 at 16:04 +0200, Daniel Lezcano wrote: > On 18/07/2022 06:59, Zhang Rui wrote: > > On Fri, 2022-07-15 at 23:09 +0200, Daniel Lezcano wrote: > > > As the trip temperature is already available when calling the > > > function > > > handle_critical_trips(), pass it as a parameter instead of having > > > this > > > function calling the ops again to retrieve the same data. > > > > > > Reviewed-by: Lukasz Luba <lukasz.luba@arm.com> > > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > > > --- > > > v3: > > > - Massaged the patch title and the description > > > --- > > > drivers/thermal/thermal_core.c | 8 ++------ > > > 1 file changed, 2 insertions(+), 6 deletions(-) > > > > > > diff --git a/drivers/thermal/thermal_core.c > > > b/drivers/thermal/thermal_core.c > > > index d9f771b15ed8..f66036b3daae 100644 > > > --- a/drivers/thermal/thermal_core.c > > > +++ b/drivers/thermal/thermal_core.c > > > @@ -340,12 +340,8 @@ void thermal_zone_device_critical(struct > > > thermal_zone_device *tz) > > > EXPORT_SYMBOL(thermal_zone_device_critical); > > > > > > static void handle_critical_trips(struct thermal_zone_device > > > *tz, > > > - int trip, enum > > > thermal_trip_type > > > trip_type) > > > + int trip, int trip_temp, enum > > > thermal_trip_type trip_type) > > > > This indent cleanup belongs to patch 1/4. > > It is not an indent cleanup, the 'int trip_temp' is added in the > parameters. Sorry, I meant the indent cleanup in Patch 3/4 can be moved to 2/4. thanks, rui > > > Other than that, > > > > Reviewed-by: Zhang Rui <rui.zhang@intel.com> > > [ ... ] > >
diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c index d9f771b15ed8..f66036b3daae 100644 --- a/drivers/thermal/thermal_core.c +++ b/drivers/thermal/thermal_core.c @@ -340,12 +340,8 @@ void thermal_zone_device_critical(struct thermal_zone_device *tz) EXPORT_SYMBOL(thermal_zone_device_critical); static void handle_critical_trips(struct thermal_zone_device *tz, - int trip, enum thermal_trip_type trip_type) + int trip, int trip_temp, enum thermal_trip_type trip_type) { - int trip_temp; - - tz->ops->get_trip_temp(tz, trip, &trip_temp); - /* If we have not crossed the trip_temp, we do not care. */ if (trip_temp <= 0 || tz->temperature < trip_temp) return; @@ -394,7 +390,7 @@ static void handle_thermal_trip(struct thermal_zone_device *tz, int trip) handle_thermal_trip_crossed(tz, trip, trip_temp, hyst, type); if (type == THERMAL_TRIP_CRITICAL || type == THERMAL_TRIP_HOT) - handle_critical_trips(tz, trip, type); + handle_critical_trips(tz, trip, trip_temp, type); else handle_non_critical_trips(tz, trip); /*