| Message ID | 20220820102925.29476-1-pali@kernel.org (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | [1/3] dt-bindings: reset: syscon-reboot: Add priority property | expand |
On Sat, 20 Aug 2022 12:29:23 +0200, Pali Rohár wrote: > This new optional priority property allows to specify custom priority level > of reset device. Default level was always 192. > > Signed-off-by: Pali Rohár <pali@kernel.org> > --- > .../devicetree/bindings/power/reset/syscon-reboot.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: ./Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml: Unresolvable JSON pointer: 'definitions/sint32' doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Sat, Aug 20, 2022 at 12:29:23PM +0200, Pali Rohár wrote: > This new optional priority property allows to specify custom priority level > of reset device. Default level was always 192. Why do we need/want this? What problem does it solve? > Signed-off-by: Pali Rohár <pali@kernel.org> > --- > .../devicetree/bindings/power/reset/syscon-reboot.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml > index da2509724812..d905133aab27 100644 > --- a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml > +++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml > @@ -42,6 +42,10 @@ properties: > $ref: /schemas/types.yaml#/definitions/uint32 > description: The reset value written to the reboot register (32 bit access). > > + priority: A bit too generic for the name. > + $ref: /schemas/types.yaml#/definitions/sint32 > + description: Priority level of this syscon reset device. Default 192. default: 192 Though I'm not really sure about the whole concept of this in DT. Where does 192 come from? Presumably if we have more than 1 reset device, then 'priority' is needed in multiple places. So you need a common schema defining the property (as property types should be defined exactly once) which this schema can reference. Rob
On Monday 22 August 2022 07:47:28 Rob Herring wrote: > On Sat, Aug 20, 2022 at 12:29:23PM +0200, Pali Rohár wrote: > > This new optional priority property allows to specify custom priority level > > of reset device. Default level was always 192. > > Why do we need/want this? What problem does it solve? See patch 3/3. > > Signed-off-by: Pali Rohár <pali@kernel.org> > > --- > > .../devicetree/bindings/power/reset/syscon-reboot.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml > > index da2509724812..d905133aab27 100644 > > --- a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml > > +++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml > > @@ -42,6 +42,10 @@ properties: > > $ref: /schemas/types.yaml#/definitions/uint32 > > description: The reset value written to the reboot register (32 bit access). > > > > + priority: > > A bit too generic for the name. > > > + $ref: /schemas/types.yaml#/definitions/sint32 > > + description: Priority level of this syscon reset device. Default 192. > > default: 192 > > > Though I'm not really sure about the whole concept of this in DT. Where > does 192 come from? Implicitly from the current implementation and how it is used. > Presumably if we have more than 1 reset device, then > 'priority' is needed in multiple places. So you need a common schema > defining the property (as property types should be defined exactly > once) which this schema can reference. > > Rob Sorry, I do not understand.
On Mon, Aug 22, 2022 at 03:50:50PM +0200, Pali Rohár wrote: > On Monday 22 August 2022 07:47:28 Rob Herring wrote: > > On Sat, Aug 20, 2022 at 12:29:23PM +0200, Pali Rohár wrote: > > > This new optional priority property allows to specify custom priority level > > > of reset device. Default level was always 192. > > > > Why do we need/want this? What problem does it solve? > > See patch 3/3. > > > > Signed-off-by: Pali Rohár <pali@kernel.org> > > > --- > > > .../devicetree/bindings/power/reset/syscon-reboot.yaml | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml > > > index da2509724812..d905133aab27 100644 > > > --- a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml > > > +++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml > > > @@ -42,6 +42,10 @@ properties: > > > $ref: /schemas/types.yaml#/definitions/uint32 > > > description: The reset value written to the reboot register (32 bit access). > > > > > > + priority: > > > > A bit too generic for the name. > > > > > + $ref: /schemas/types.yaml#/definitions/sint32 > > > + description: Priority level of this syscon reset device. Default 192. > > > > default: 192 > > > > > > Though I'm not really sure about the whole concept of this in DT. Where > > does 192 come from? > > Implicitly from the current implementation and how it is used. Implementation of what? u-boot? BSD? robOS? > > Presumably if we have more than 1 reset device, then > > 'priority' is needed in multiple places. So you need a common schema > > defining the property (as property types should be defined exactly > > once) which this schema can reference. > > > > Rob > > Sorry, I do not understand. So just keep sending new versions instead? syscon-reboot is not the only binding for a system reset device, right? So those others reset devices will need 'priority' too. For a given property, there should only be one schema definition defining the type for the property. Otherwise, there might be conflicts. So you need a common schema doing that. And here you would just have 'priority: true' or possibly some binding specific constraints. Rob
On 02/09/2022 22:37, Rob Herring wrote: >> >> Sorry, I do not understand. > > So just keep sending new versions instead? > > syscon-reboot is not the only binding for a system reset device, right? > So those others reset devices will need 'priority' too. For a given > property, there should only be one schema definition defining the type > for the property. Otherwise, there might be conflicts. So you need a > common schema doing that. And here you would just have 'priority: true' > or possibly some binding specific constraints. I'll propose a patch for this. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml index da2509724812..d905133aab27 100644 --- a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml +++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml @@ -42,6 +42,10 @@ properties: $ref: /schemas/types.yaml#/definitions/uint32 description: The reset value written to the reboot register (32 bit access). + priority: + $ref: /schemas/types.yaml#/definitions/sint32 + description: Priority level of this syscon reset device. Default 192. + required: - compatible - offset
This new optional priority property allows to specify custom priority level of reset device. Default level was always 192. Signed-off-by: Pali Rohár <pali@kernel.org> --- .../devicetree/bindings/power/reset/syscon-reboot.yaml | 4 ++++ 1 file changed, 4 insertions(+)