| Message ID | 20220923100529.17107-1-shangxiaojing@huawei.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | [-next] interconnect: qcom: icc-rpm: Remove redundant dev_err call | expand |
On 23/09/2022 12:05, Shang XiaoJing wrote: > devm_ioremap_resource() prints error message in itself. Remove the > dev_err call to avoid redundant error message. > > Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com> > --- > drivers/interconnect/qcom/icc-rpm.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c > index 39e43b957599..b808805557f1 100644 > --- a/drivers/interconnect/qcom/icc-rpm.c > +++ b/drivers/interconnect/qcom/icc-rpm.c > @@ -478,10 +478,8 @@ int qnoc_probe(struct platform_device *pdev) > > mmio = devm_ioremap_resource(dev, res); > Drop this empty line as well, please. > - if (IS_ERR(mmio)) { Best regards, Krzysztof
On 2022/9/24 3:20, Krzysztof Kozlowski wrote: > On 23/09/2022 12:05, Shang XiaoJing wrote: >> devm_ioremap_resource() prints error message in itself. Remove the >> dev_err call to avoid redundant error message. >> >> Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com> >> --- >> drivers/interconnect/qcom/icc-rpm.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c >> index 39e43b957599..b808805557f1 100644 >> --- a/drivers/interconnect/qcom/icc-rpm.c >> +++ b/drivers/interconnect/qcom/icc-rpm.c >> @@ -478,10 +478,8 @@ int qnoc_probe(struct platform_device *pdev) >> >> mmio = devm_ioremap_resource(dev, res); >> > Drop this empty line as well, please. thanks for the review, will fix in v2. Thanks, Shang XiaoJing
diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c index 39e43b957599..b808805557f1 100644 --- a/drivers/interconnect/qcom/icc-rpm.c +++ b/drivers/interconnect/qcom/icc-rpm.c @@ -478,10 +478,8 @@ int qnoc_probe(struct platform_device *pdev) mmio = devm_ioremap_resource(dev, res); - if (IS_ERR(mmio)) { - dev_err(dev, "Cannot ioremap interconnect bus resource\n"); + if (IS_ERR(mmio)) return PTR_ERR(mmio); - } qp->regmap = devm_regmap_init_mmio(dev, mmio, desc->regmap_cfg); if (IS_ERR(qp->regmap)) {
devm_ioremap_resource() prints error message in itself. Remove the dev_err call to avoid redundant error message. Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com> --- drivers/interconnect/qcom/icc-rpm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)