| Message ID | 20221010034126.3550-1-j-keerthy@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Daniel Lezcano |
| Headers | show |
| Series | thermal: k3_j72xx_bandgap: Fix the debug print message | expand |
On 10/10/2022 05:41, Keerthy wrote: > The debug print message to check the workaround applicability is inverted. > Fix the same. > > Fixes: ffcb2fc86eb7 ("thermal: k3_j72xx_bandgap: Add the bandgap driver support") > Reported-by: Bryan Brattlof <bb@ti.com> > Signed-off-by: Keerthy <j-keerthy@ti.com> > --- Applied, thanks BTW, Kheerty, if you have time is it possible to convert the k3_bandgap.c with the pre-computed factors like the k3_j72xx_bandgap.c, so both can be merged ?
On 10/17/2022 1:02 PM, Daniel Lezcano wrote: > On 10/10/2022 05:41, Keerthy wrote: >> The debug print message to check the workaround applicability is >> inverted. >> Fix the same. >> >> Fixes: ffcb2fc86eb7 ("thermal: k3_j72xx_bandgap: Add the bandgap >> driver support") >> Reported-by: Bryan Brattlof <bb@ti.com> >> Signed-off-by: Keerthy <j-keerthy@ti.com> >> --- > > Applied, thanks > > BTW, Kheerty, if you have time is it possible to convert the > k3_bandgap.c with the pre-computed factors like the k3_j72xx_bandgap.c, > so both can be merged ? Okay. I will try that out in a couple of weeks time. Thanks, Keerthy > > > >
On 17/10/2022 09:38, J, KEERTHY wrote: > > > On 10/17/2022 1:02 PM, Daniel Lezcano wrote: >> On 10/10/2022 05:41, Keerthy wrote: >>> The debug print message to check the workaround applicability is >>> inverted. >>> Fix the same. >>> >>> Fixes: ffcb2fc86eb7 ("thermal: k3_j72xx_bandgap: Add the bandgap >>> driver support") >>> Reported-by: Bryan Brattlof <bb@ti.com> >>> Signed-off-by: Keerthy <j-keerthy@ti.com> >>> --- >> >> Applied, thanks >> >> BTW, Kheerty, if you have time is it possible to convert the >> k3_bandgap.c with the pre-computed factors like the >> k3_j72xx_bandgap.c, so both can be merged ? > > Okay. I will try that out in a couple of weeks time. Great, thanks!
diff --git a/drivers/thermal/k3_j72xx_bandgap.c b/drivers/thermal/k3_j72xx_bandgap.c index 16b6bcf1bf4f..c073b1023bbe 100644 --- a/drivers/thermal/k3_j72xx_bandgap.c +++ b/drivers/thermal/k3_j72xx_bandgap.c @@ -439,7 +439,7 @@ static int k3_j72xx_bandgap_probe(struct platform_device *pdev) workaround_needed = false; dev_dbg(bgp->dev, "Work around %sneeded\n", - workaround_needed ? "not " : ""); + workaround_needed ? "" : "not "); if (!workaround_needed) init_table(5, ref_table, golden_factors);
The debug print message to check the workaround applicability is inverted. Fix the same. Fixes: ffcb2fc86eb7 ("thermal: k3_j72xx_bandgap: Add the bandgap driver support") Reported-by: Bryan Brattlof <bb@ti.com> Signed-off-by: Keerthy <j-keerthy@ti.com> --- drivers/thermal/k3_j72xx_bandgap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)