| Message ID | 20221020115513.93809-1-ulf.hansson@linaro.org (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Headers | show |
| Series | cpuidle: psci: Extend information in log about OSI/PC mode | expand |
On Thu, Oct 20, 2022 at 01:55:13PM +0200, Ulf Hansson wrote: > It's useful to understand whether we are using OS-initiated (OSI) mode or > Platform Coordinated (PC) mode, when initializing the CPU PM domains. > Therefore, let's extend the print in the log after a successful probe with > this information. > Looks good to me. Acked-by: Sudeep Holla <sudeep.holla@arm.com
On 20/10/2022 14:55, Ulf Hansson wrote: > It's useful to understand whether we are using OS-initiated (OSI) mode or > Platform Coordinated (PC) mode, when initializing the CPU PM domains. > Therefore, let's extend the print in the log after a successful probe with > this information. > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > drivers/cpuidle/cpuidle-psci-domain.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Acked-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Thu, Oct 20, 2022 at 1:55 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > It's useful to understand whether we are using OS-initiated (OSI) mode or > Platform Coordinated (PC) mode, when initializing the CPU PM domains. > Therefore, let's extend the print in the log after a successful probe with > this information. > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > drivers/cpuidle/cpuidle-psci-domain.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c > index 821984947ed9..c80cf9ddabd8 100644 > --- a/drivers/cpuidle/cpuidle-psci-domain.c > +++ b/drivers/cpuidle/cpuidle-psci-domain.c > @@ -181,7 +181,8 @@ static int psci_cpuidle_domain_probe(struct platform_device *pdev) > if (ret) > goto remove_pd; > > - pr_info("Initialized CPU PM domain topology\n"); > + pr_info("Initialized CPU PM domain topology using %s mode\n", > + use_osi ? "OSI" : "PC"); > return 0; > > put_node: > -- Am I expected to pick up this one?
On Tue, 25 Oct 2022 at 15:16, Rafael J. Wysocki <rafael@kernel.org> wrote: > > On Thu, Oct 20, 2022 at 1:55 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > > > It's useful to understand whether we are using OS-initiated (OSI) mode or > > Platform Coordinated (PC) mode, when initializing the CPU PM domains. > > Therefore, let's extend the print in the log after a successful probe with > > this information. > > > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > > --- > > drivers/cpuidle/cpuidle-psci-domain.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c > > index 821984947ed9..c80cf9ddabd8 100644 > > --- a/drivers/cpuidle/cpuidle-psci-domain.c > > +++ b/drivers/cpuidle/cpuidle-psci-domain.c > > @@ -181,7 +181,8 @@ static int psci_cpuidle_domain_probe(struct platform_device *pdev) > > if (ret) > > goto remove_pd; > > > > - pr_info("Initialized CPU PM domain topology\n"); > > + pr_info("Initialized CPU PM domain topology using %s mode\n", > > + use_osi ? "OSI" : "PC"); > > return 0; > > > > put_node: > > -- > > Am I expected to pick up this one? Yes, please! Kind regards Uffe
On Tue, Oct 25, 2022 at 3:18 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > On Tue, 25 Oct 2022 at 15:16, Rafael J. Wysocki <rafael@kernel.org> wrote: > > > > On Thu, Oct 20, 2022 at 1:55 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > > > > > It's useful to understand whether we are using OS-initiated (OSI) mode or > > > Platform Coordinated (PC) mode, when initializing the CPU PM domains. > > > Therefore, let's extend the print in the log after a successful probe with > > > this information. > > > > > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > > > --- > > > drivers/cpuidle/cpuidle-psci-domain.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c > > > index 821984947ed9..c80cf9ddabd8 100644 > > > --- a/drivers/cpuidle/cpuidle-psci-domain.c > > > +++ b/drivers/cpuidle/cpuidle-psci-domain.c > > > @@ -181,7 +181,8 @@ static int psci_cpuidle_domain_probe(struct platform_device *pdev) > > > if (ret) > > > goto remove_pd; > > > > > > - pr_info("Initialized CPU PM domain topology\n"); > > > + pr_info("Initialized CPU PM domain topology using %s mode\n", > > > + use_osi ? "OSI" : "PC"); > > > return 0; > > > > > > put_node: > > > -- > > > > Am I expected to pick up this one? > > Yes, please! Done, thanks!
diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c index 821984947ed9..c80cf9ddabd8 100644 --- a/drivers/cpuidle/cpuidle-psci-domain.c +++ b/drivers/cpuidle/cpuidle-psci-domain.c @@ -181,7 +181,8 @@ static int psci_cpuidle_domain_probe(struct platform_device *pdev) if (ret) goto remove_pd; - pr_info("Initialized CPU PM domain topology\n"); + pr_info("Initialized CPU PM domain topology using %s mode\n", + use_osi ? "OSI" : "PC"); return 0; put_node:
It's useful to understand whether we are using OS-initiated (OSI) mode or Platform Coordinated (PC) mode, when initializing the CPU PM domains. Therefore, let's extend the print in the log after a successful probe with this information. Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> --- drivers/cpuidle/cpuidle-psci-domain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)