| Message ID | 20221103143654.85275-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Headers | show |
| Series | cpufreq: SPEAr: Make read-only array sys_clk_src static | expand |
On 03-11-22, 14:36, Colin Ian King wrote: > Don't populate the read-only array sys_clk_src on the stack but instead > make it static and add in a missing const. Also makes the object code a > little smaller. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > drivers/cpufreq/spear-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/spear-cpufreq.c b/drivers/cpufreq/spear-cpufreq.c > index 7d0d62a06bf3..c6fdf019dbde 100644 > --- a/drivers/cpufreq/spear-cpufreq.c > +++ b/drivers/cpufreq/spear-cpufreq.c > @@ -39,7 +39,7 @@ static struct clk *spear1340_cpu_get_possible_parent(unsigned long newfreq) > * In SPEAr1340, cpu clk's parent sys clk can take input from > * following sources > */ > - const char *sys_clk_src[] = { > + static const char * const sys_clk_src[] = { > "sys_syn_clk", > "pll1_clk", > "pll2_clk", Same questions from longhaul patch apply here too.
On 03/11/2022 14:38, Viresh Kumar wrote: > On 03-11-22, 14:36, Colin Ian King wrote: >> Don't populate the read-only array sys_clk_src on the stack but instead >> make it static and add in a missing const. Also makes the object code a >> little smaller. >> >> Signed-off-by: Colin Ian King <colin.i.king@gmail.com> >> --- >> drivers/cpufreq/spear-cpufreq.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/cpufreq/spear-cpufreq.c b/drivers/cpufreq/spear-cpufreq.c >> index 7d0d62a06bf3..c6fdf019dbde 100644 >> --- a/drivers/cpufreq/spear-cpufreq.c >> +++ b/drivers/cpufreq/spear-cpufreq.c >> @@ -39,7 +39,7 @@ static struct clk *spear1340_cpu_get_possible_parent(unsigned long newfreq) >> * In SPEAr1340, cpu clk's parent sys clk can take input from >> * following sources >> */ >> - const char *sys_clk_src[] = { >> + static const char * const sys_clk_src[] = { >> "sys_syn_clk", >> "pll1_clk", >> "pll2_clk", > > Same questions from longhaul patch apply here too. > See answer in that patch :-) But really, this is kind of basic C level stuff. I suggest reading K&R 2nd Edition, Section 4.6, last paragraph before exercise 4-11.
On Thu, Nov 3, 2022 at 3:37 PM Colin Ian King <colin.i.king@gmail.com> wrote: > > Don't populate the read-only array sys_clk_src on the stack but instead > make it static and add in a missing const. Also makes the object code a > little smaller. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > drivers/cpufreq/spear-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/spear-cpufreq.c b/drivers/cpufreq/spear-cpufreq.c > index 7d0d62a06bf3..c6fdf019dbde 100644 > --- a/drivers/cpufreq/spear-cpufreq.c > +++ b/drivers/cpufreq/spear-cpufreq.c > @@ -39,7 +39,7 @@ static struct clk *spear1340_cpu_get_possible_parent(unsigned long newfreq) > * In SPEAr1340, cpu clk's parent sys clk can take input from > * following sources > */ > - const char *sys_clk_src[] = { > + static const char * const sys_clk_src[] = { > "sys_syn_clk", > "pll1_clk", > "pll2_clk", > -- Applied as 6.2 material, thanks!
On 03-11-22, 14:49, Colin King (gmail) wrote: > But really, this is kind of basic C level stuff. I suggest reading K&R 2nd > Edition, Section 4.6, last paragraph before exercise 4-11. Yeah it is and I said this for the benefit of later readers of the commit log, who may not know the exact reason of the same: "I am just looking for a valid answer in commit log". Anyway, the patches look fine otherwise.
On Thu, 2022-11-03 at 14:36 +0000, Colin Ian King wrote: > Don't populate the read-only array sys_clk_src on the stack but instead > make it static and add in a missing const. Also makes the object code a > little smaller. [] > diff --git a/drivers/cpufreq/spear-cpufreq.c b/drivers/cpufreq/spear-cpufreq.c [] > @@ -39,7 +39,7 @@ static struct clk *spear1340_cpu_get_possible_parent(unsigned long newfreq) > * In SPEAr1340, cpu clk's parent sys clk can take input from > * following sources > */ > - const char *sys_clk_src[] = { > + static const char * const sys_clk_src[] = { > "sys_syn_clk", > "pll1_clk", > "pll2_clk", sys_clk_src[2] isn't used and could be deleted with the pclk indices changed. Dunno what happened to the > 500000000 && != 600000000 range.
diff --git a/drivers/cpufreq/spear-cpufreq.c b/drivers/cpufreq/spear-cpufreq.c index 7d0d62a06bf3..c6fdf019dbde 100644 --- a/drivers/cpufreq/spear-cpufreq.c +++ b/drivers/cpufreq/spear-cpufreq.c @@ -39,7 +39,7 @@ static struct clk *spear1340_cpu_get_possible_parent(unsigned long newfreq) * In SPEAr1340, cpu clk's parent sys clk can take input from * following sources */ - const char *sys_clk_src[] = { + static const char * const sys_clk_src[] = { "sys_syn_clk", "pll1_clk", "pll2_clk",
Don't populate the read-only array sys_clk_src on the stack but instead make it static and add in a missing const. Also makes the object code a little smaller. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/cpufreq/spear-cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)