| Message ID | 20221103150431.87598-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Headers | show |
| Series | [V2] cpufreq: longhaul: Make array speeds static const | expand |
On Thu, Nov 3, 2022 at 4:04 PM Colin Ian King <colin.i.king@gmail.com> wrote: > > Don't populate the read-only array speeds on the stack but instead > make it static. Also makes the object code a little smaller. Replace > hard-coded loop array bounds with ARRAY_SIZE. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > V2: replace 4 with ARRAY_SIZE in for-loop as suggested by Joe Perches. > --- > drivers/cpufreq/longhaul.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/longhaul.c b/drivers/cpufreq/longhaul.c > index 3e000e1a75c6..4c57c6725c13 100644 > --- a/drivers/cpufreq/longhaul.c > +++ b/drivers/cpufreq/longhaul.c > @@ -407,10 +407,10 @@ static int guess_fsb(int mult) > { > int speed = cpu_khz / 1000; > int i; > - int speeds[] = { 666, 1000, 1333, 2000 }; > + static const int speeds[] = { 666, 1000, 1333, 2000 }; > int f_max, f_min; > > - for (i = 0; i < 4; i++) { > + for (i = 0; i < ARRAY_SIZE(speeds); i++) { > f_max = ((speeds[i] * mult) + 50) / 100; > f_max += (ROUNDING / 2); > f_min = f_max - ROUNDING; > -- Applied as 6.2 material, thanks!
diff --git a/drivers/cpufreq/longhaul.c b/drivers/cpufreq/longhaul.c index 3e000e1a75c6..4c57c6725c13 100644 --- a/drivers/cpufreq/longhaul.c +++ b/drivers/cpufreq/longhaul.c @@ -407,10 +407,10 @@ static int guess_fsb(int mult) { int speed = cpu_khz / 1000; int i; - int speeds[] = { 666, 1000, 1333, 2000 }; + static const int speeds[] = { 666, 1000, 1333, 2000 }; int f_max, f_min; - for (i = 0; i < 4; i++) { + for (i = 0; i < ARRAY_SIZE(speeds); i++) { f_max = ((speeds[i] * mult) + 50) / 100; f_max += (ROUNDING / 2); f_min = f_max - ROUNDING;
Don't populate the read-only array speeds on the stack but instead make it static. Also makes the object code a little smaller. Replace hard-coded loop array bounds with ARRAY_SIZE. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- V2: replace 4 with ARRAY_SIZE in for-loop as suggested by Joe Perches. --- drivers/cpufreq/longhaul.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)