Message ID | 202212081706290141979@zte.com.cn (mailing list archive) |
---|---|
State | Deferred, archived |
Headers | show |
Series | thermal: Convert to use sysfs_emit_at() API | expand |
On Thu, Dec 8, 2022 at 10:06 AM <ye.xingchen@zte.com.cn> wrote: > > From: ye xingchen <ye.xingchen@zte.com.cn> > > Follow the advice of the Documentation/filesystems/sysfs.rst and show() > should only use sysfs_emit() or sysfs_emit_at() when formatting the > value to be returned to user space. > > Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn> Again, please resend this after 6.2-rc1 is out, thanks! > --- > drivers/thermal/thermal_core.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c > index f17ab2316dbd..91d40ce62c92 100644 > --- a/drivers/thermal/thermal_core.c > +++ b/drivers/thermal/thermal_core.c > @@ -229,10 +229,9 @@ int thermal_build_list_of_policies(char *buf) > mutex_lock(&thermal_governor_lock); > > list_for_each_entry(pos, &thermal_governor_list, governor_list) { > - count += scnprintf(buf + count, PAGE_SIZE - count, "%s ", > - pos->name); > + count += sysfs_emit_at(buf, count, "%s ", pos->name); > } > - count += scnprintf(buf + count, PAGE_SIZE - count, "\n"); > + count += sysfs_emit_at(buf, count, "\n"); > > mutex_unlock(&thermal_governor_lock); > > -- > 2.25.1
diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c index f17ab2316dbd..91d40ce62c92 100644 --- a/drivers/thermal/thermal_core.c +++ b/drivers/thermal/thermal_core.c @@ -229,10 +229,9 @@ int thermal_build_list_of_policies(char *buf) mutex_lock(&thermal_governor_lock); list_for_each_entry(pos, &thermal_governor_list, governor_list) { - count += scnprintf(buf + count, PAGE_SIZE - count, "%s ", - pos->name); + count += sysfs_emit_at(buf, count, "%s ", pos->name); } - count += scnprintf(buf + count, PAGE_SIZE - count, "\n"); + count += sysfs_emit_at(buf, count, "\n"); mutex_unlock(&thermal_governor_lock);