| Message ID | 20230407150326.80183-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | power: supply: hwmon: constify pointers to hwmon_channel_info | expand |
Hi, On Fri, Apr 07, 2023 at 05:03:26PM +0200, Krzysztof Kozlowski wrote: > Statically allocated array of pointed to hwmon_channel_info can be > made const for safety. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > This depends on hwmon core patch: > https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski@linaro.org/ > > Therefore I propose this should also go via hwmon tree. > > Cc: Jean Delvare <jdelvare@suse.com> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: linux-hwmon@vger.kernel.org > --- Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com> -- Sebastian > drivers/power/supply/power_supply_hwmon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/supply/power_supply_hwmon.c b/drivers/power/supply/power_supply_hwmon.c > index a48aa4afb828..c97893d4c25e 100644 > --- a/drivers/power/supply/power_supply_hwmon.c > +++ b/drivers/power/supply/power_supply_hwmon.c > @@ -293,7 +293,7 @@ static const struct hwmon_ops power_supply_hwmon_ops = { > .read_string = power_supply_hwmon_read_string, > }; > > -static const struct hwmon_channel_info *power_supply_hwmon_info[] = { > +static const struct hwmon_channel_info * const power_supply_hwmon_info[] = { > HWMON_CHANNEL_INFO(temp, > HWMON_T_LABEL | > HWMON_T_INPUT | > -- > 2.34.1 >
On 4/7/23 15:12, Sebastian Reichel wrote: > Hi, > > On Fri, Apr 07, 2023 at 05:03:26PM +0200, Krzysztof Kozlowski wrote: >> Statically allocated array of pointed to hwmon_channel_info can be >> made const for safety. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> This depends on hwmon core patch: >> https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski@linaro.org/ >> >> Therefore I propose this should also go via hwmon tree. >> I am not going to apply patches for 10+ subsystems through the hwmon tree. This can only result in chaos. The dependent patch is available at git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-const or wait until after the next commit window to apply this patch. Thanks, Guenter >> Cc: Jean Delvare <jdelvare@suse.com> >> Cc: Guenter Roeck <linux@roeck-us.net> >> Cc: linux-hwmon@vger.kernel.org >> --- > > Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com> > > -- Sebastian > >> drivers/power/supply/power_supply_hwmon.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/power/supply/power_supply_hwmon.c b/drivers/power/supply/power_supply_hwmon.c >> index a48aa4afb828..c97893d4c25e 100644 >> --- a/drivers/power/supply/power_supply_hwmon.c >> +++ b/drivers/power/supply/power_supply_hwmon.c >> @@ -293,7 +293,7 @@ static const struct hwmon_ops power_supply_hwmon_ops = { >> .read_string = power_supply_hwmon_read_string, >> }; >> >> -static const struct hwmon_channel_info *power_supply_hwmon_info[] = { >> +static const struct hwmon_channel_info * const power_supply_hwmon_info[] = { >> HWMON_CHANNEL_INFO(temp, >> HWMON_T_LABEL | >> HWMON_T_INPUT | >> -- >> 2.34.1 >>
Hi, On Fri, Apr 07, 2023 at 05:03:26PM +0200, Krzysztof Kozlowski wrote: > Statically allocated array of pointed to hwmon_channel_info can be made > const for safety. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > This depends on hwmon core patch: > https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski@linaro.org/ > > Therefore I propose this should also go via hwmon tree. > > Cc: Jean Delvare <jdelvare@suse.com> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: linux-hwmon@vger.kernel.org > --- Thanks, queued (to my for-next branch). -- Sebastian > drivers/power/supply/power_supply_hwmon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/supply/power_supply_hwmon.c b/drivers/power/supply/power_supply_hwmon.c > index a48aa4afb828..c97893d4c25e 100644 > --- a/drivers/power/supply/power_supply_hwmon.c > +++ b/drivers/power/supply/power_supply_hwmon.c > @@ -293,7 +293,7 @@ static const struct hwmon_ops power_supply_hwmon_ops = { > .read_string = power_supply_hwmon_read_string, > }; > > -static const struct hwmon_channel_info *power_supply_hwmon_info[] = { > +static const struct hwmon_channel_info * const power_supply_hwmon_info[] = { > HWMON_CHANNEL_INFO(temp, > HWMON_T_LABEL | > HWMON_T_INPUT | > -- > 2.34.1 >
diff --git a/drivers/power/supply/power_supply_hwmon.c b/drivers/power/supply/power_supply_hwmon.c index a48aa4afb828..c97893d4c25e 100644 --- a/drivers/power/supply/power_supply_hwmon.c +++ b/drivers/power/supply/power_supply_hwmon.c @@ -293,7 +293,7 @@ static const struct hwmon_ops power_supply_hwmon_ops = { .read_string = power_supply_hwmon_read_string, }; -static const struct hwmon_channel_info *power_supply_hwmon_info[] = { +static const struct hwmon_channel_info * const power_supply_hwmon_info[] = { HWMON_CHANNEL_INFO(temp, HWMON_T_LABEL | HWMON_T_INPUT |
Statically allocated array of pointed to hwmon_channel_info can be made const for safety. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- This depends on hwmon core patch: https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski@linaro.org/ Therefore I propose this should also go via hwmon tree. Cc: Jean Delvare <jdelvare@suse.com> Cc: Guenter Roeck <linux@roeck-us.net> Cc: linux-hwmon@vger.kernel.org --- drivers/power/supply/power_supply_hwmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)