| Message ID | 20230508071200.123962-6-wangkefeng.wang@huawei.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | mm: page_alloc: misc cleanup and refector | expand |
On Mon, May 08, 2023 at 03:11:53PM +0800, Kefeng Wang wrote: > Squash the page_is_consistent() into bad_range() as there is > only one caller. > > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> Reviewed-by: Mike Rapoport (IBM) <rppt@kernel.org> > --- > mm/page_alloc.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 9a85238f1140..348dcbaca757 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -517,13 +517,6 @@ static int page_outside_zone_boundaries(struct zone *zone, struct page *page) > return ret; > } > > -static int page_is_consistent(struct zone *zone, struct page *page) > -{ > - if (zone != page_zone(page)) > - return 0; > - > - return 1; > -} > /* > * Temporary debugging check for pages not lying within a given zone. > */ > @@ -531,7 +524,7 @@ static int __maybe_unused bad_range(struct zone *zone, struct page *page) > { > if (page_outside_zone_boundaries(zone, page)) > return 1; > - if (!page_is_consistent(zone, page)) > + if (zone != page_zone(page)) > return 1; > > return 0; > -- > 2.35.3 >
diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 9a85238f1140..348dcbaca757 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -517,13 +517,6 @@ static int page_outside_zone_boundaries(struct zone *zone, struct page *page) return ret; } -static int page_is_consistent(struct zone *zone, struct page *page) -{ - if (zone != page_zone(page)) - return 0; - - return 1; -} /* * Temporary debugging check for pages not lying within a given zone. */ @@ -531,7 +524,7 @@ static int __maybe_unused bad_range(struct zone *zone, struct page *page) { if (page_outside_zone_boundaries(zone, page)) return 1; - if (!page_is_consistent(zone, page)) + if (zone != page_zone(page)) return 1; return 0;
Squash the page_is_consistent() into bad_range() as there is only one caller. Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> --- mm/page_alloc.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)