| Message ID | 20230626134645.57902-1-ahalaney@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | viresh kumar |
| Headers | show |
| Series | OPP: Properly propagate error along when failing to get icc_path | expand |
On 26-06-23, 08:46, Andrew Halaney wrote: > fa155f4f8348 ("OPP: Use dev_err_probe() when failing to get icc_path") > failed to actually use the error it was trying to log: > > smatch warnings: > drivers/opp/of.c:516 dev_pm_opp_of_find_icc_paths() warn: passing zero to 'dev_err_probe' > > Make sure to use the right error and pass it along. > > Fixes: fa155f4f8348 ("OPP: Use dev_err_probe() when failing to get icc_path") > Reported-by: kernel test robot <lkp@intel.com> > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > Closes: https://lore.kernel.org/r/202306262008.guNLgjt6-lkp@intel.com/ > Signed-off-by: Andrew Halaney <ahalaney@redhat.com> Applied. Thanks.
diff --git a/drivers/opp/of.c b/drivers/opp/of.c index 1f0923cc1cd9..ada4963c7cfa 100644 --- a/drivers/opp/of.c +++ b/drivers/opp/of.c @@ -513,7 +513,7 @@ int dev_pm_opp_of_find_icc_paths(struct device *dev, for (i = 0; i < num_paths; i++) { paths[i] = of_icc_get_by_index(dev, i); if (IS_ERR(paths[i])) { - ret = dev_err_probe(dev, ret, "%s: Unable to get path%d\n", __func__, i); + ret = dev_err_probe(dev, PTR_ERR(paths[i]), "%s: Unable to get path%d\n", __func__, i); goto err; } }
fa155f4f8348 ("OPP: Use dev_err_probe() when failing to get icc_path") failed to actually use the error it was trying to log: smatch warnings: drivers/opp/of.c:516 dev_pm_opp_of_find_icc_paths() warn: passing zero to 'dev_err_probe' Make sure to use the right error and pass it along. Fixes: fa155f4f8348 ("OPP: Use dev_err_probe() when failing to get icc_path") Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Closes: https://lore.kernel.org/r/202306262008.guNLgjt6-lkp@intel.com/ Signed-off-by: Andrew Halaney <ahalaney@redhat.com> --- This slip up was totally my fault, apologies. I've got a "dirty" working tree (where I made this enhancement while debugging) and a clean tree for submitting patches along the way. It looks like I made a slight change in the patch that was sent in the clean tree, then rebuilt and tested the dirty tree and sent it off. Won't happen again, embarrassed to admit I sent a patch that was not properly tested but oh well. Here's a fix. Thanks, Andrew drivers/opp/of.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)