diff mbox series

[12/18] soc: starfive: Move the power-domain driver to the genpd dir

Message ID 20230707140434.723349-13-ulf.hansson@linaro.org (mailing list archive)
State Superseded, archived
Headers show
Series genpd: Create a genpd directory to host genpd providers | expand

Commit Message

Ulf Hansson July 7, 2023, 2:04 p.m. UTC
Cc: Walker Chen <walker.chen@starfivetech.com>
Cc: Conor Dooley <conor@kernel.org>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
 MAINTAINERS                                                    | 2 +-
 drivers/genpd/Makefile                                         | 1 +
 drivers/genpd/starfive/Makefile                                | 2 ++
 .../{soc/starfive/jh71xx_pmu.c => genpd/starfive/jh71xx-pmu.c} | 0
 drivers/soc/starfive/Makefile                                  | 3 ---
 5 files changed, 4 insertions(+), 4 deletions(-)
 create mode 100644 drivers/genpd/starfive/Makefile
 rename drivers/{soc/starfive/jh71xx_pmu.c => genpd/starfive/jh71xx-pmu.c} (100%)
 delete mode 100644 drivers/soc/starfive/Makefile

Comments

Conor Dooley July 7, 2023, 3:51 p.m. UTC | #1
On Fri, Jul 07, 2023 at 04:04:28PM +0200, Ulf Hansson wrote:
> Cc: Walker Chen <walker.chen@starfivetech.com>
> Cc: Conor Dooley <conor@kernel.org>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

If you are not going to write a commit message with an explanation,
the least you could do is CC me on the cover letter.

> ---
>  MAINTAINERS                                                    | 2 +-
>  drivers/genpd/Makefile                                         | 1 +
>  drivers/genpd/starfive/Makefile                                | 2 ++
>  .../{soc/starfive/jh71xx_pmu.c => genpd/starfive/jh71xx-pmu.c} | 0
>  drivers/soc/starfive/Makefile                                  | 3 ---

Why not also move the Kconfig entry while you are at it?

Thanks,
Conor.
Ulf Hansson July 11, 2023, 1:57 p.m. UTC | #2
On Fri, 7 Jul 2023 at 17:51, Conor Dooley <conor@kernel.org> wrote:
>
> On Fri, Jul 07, 2023 at 04:04:28PM +0200, Ulf Hansson wrote:
> > Cc: Walker Chen <walker.chen@starfivetech.com>
> > Cc: Conor Dooley <conor@kernel.org>
> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>
> If you are not going to write a commit message with an explanation,

I will, sorry for being lazy.

> the least you could do is CC me on the cover letter.

Yes, I will soon post a new version and add you to the cover letter and patch 1.

>
> > ---
> >  MAINTAINERS                                                    | 2 +-
> >  drivers/genpd/Makefile                                         | 1 +
> >  drivers/genpd/starfive/Makefile                                | 2 ++
> >  .../{soc/starfive/jh71xx_pmu.c => genpd/starfive/jh71xx-pmu.c} | 0
> >  drivers/soc/starfive/Makefile                                  | 3 ---
>
> Why not also move the Kconfig entry while you are at it?

I just replied to Geert [1], who had similar questions. Hope that
makes sense to you?

>
> Thanks,
> Conor.

[1]
https://lore.kernel.org/lkml/CAPDyKFrsBV=7CDDiZcAJDRiZsze4fcWq5tCR8zYCRyeTUu5hqA@mail.gmail.com/
Conor Dooley July 11, 2023, 4:07 p.m. UTC | #3
On Tue, Jul 11, 2023 at 03:57:49PM +0200, Ulf Hansson wrote:
> On Fri, 7 Jul 2023 at 17:51, Conor Dooley <conor@kernel.org> wrote:
> >
> > On Fri, Jul 07, 2023 at 04:04:28PM +0200, Ulf Hansson wrote:
> > > Cc: Walker Chen <walker.chen@starfivetech.com>
> > > Cc: Conor Dooley <conor@kernel.org>
> > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> >

> > If you are not going to write a commit message with an explanation,
> 
> I will, sorry for being lazy.
> 
> > the least you could do is CC me on the cover letter.
> 
> Yes, I will soon post a new version and add you to the cover letter and patch 1.

Thanks. Obviously I was able to pull the message-id & look at lore etc,
but what goes for the goose, goes for the gander and all that.

> > > ---
> > >  MAINTAINERS                                                    | 2 +-
> > >  drivers/genpd/Makefile                                         | 1 +
> > >  drivers/genpd/starfive/Makefile                                | 2 ++
> > >  .../{soc/starfive/jh71xx_pmu.c => genpd/starfive/jh71xx-pmu.c} | 0
> > >  drivers/soc/starfive/Makefile                                  | 3 ---
> >
> > Why not also move the Kconfig entry while you are at it?
> 
> I just replied to Geert [1], who had similar questions. Hope that
> makes sense to you?

In general, it does explain why you did not do it.
I think that the Kconfig stuff should move too & the whole
soc/starfive directory should vanish, but that could be left for a
follow-up activity.

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index cb57f5fb2cd7..9e580df3e5db 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -20311,7 +20311,7 @@  STARFIVE JH71XX PMU CONTROLLER DRIVER
 M:	Walker Chen <walker.chen@starfivetech.com>
 S:	Supported
 F:	Documentation/devicetree/bindings/power/starfive*
-F:	drivers/soc/starfive/jh71xx_pmu.c
+F:	drivers/genpd/starfive/jh71xx-pmu.c
 F:	include/dt-bindings/power/starfive,jh7110-pmu.h
 
 STARFIVE JH7110 TDM DRIVER
diff --git a/drivers/genpd/Makefile b/drivers/genpd/Makefile
index 1cf0ff26a44f..baf2021235a7 100644
--- a/drivers/genpd/Makefile
+++ b/drivers/genpd/Makefile
@@ -8,3 +8,4 @@  obj-y					+= qcom/
 obj-y					+= renesas/
 obj-y					+= rockchip/
 obj-y					+= samsung/
+obj-y					+= starfive/
diff --git a/drivers/genpd/starfive/Makefile b/drivers/genpd/starfive/Makefile
new file mode 100644
index 000000000000..975bba2a29a9
--- /dev/null
+++ b/drivers/genpd/starfive/Makefile
@@ -0,0 +1,2 @@ 
+# SPDX-License-Identifier: GPL-2.0
+obj-$(CONFIG_JH71XX_PMU)		+= jh71xx-pmu.o
diff --git a/drivers/soc/starfive/jh71xx_pmu.c b/drivers/genpd/starfive/jh71xx-pmu.c
similarity index 100%
rename from drivers/soc/starfive/jh71xx_pmu.c
rename to drivers/genpd/starfive/jh71xx-pmu.c
diff --git a/drivers/soc/starfive/Makefile b/drivers/soc/starfive/Makefile
deleted file mode 100644
index 13b589d6b5f3..000000000000
--- a/drivers/soc/starfive/Makefile
+++ /dev/null
@@ -1,3 +0,0 @@ 
-# SPDX-License-Identifier: GPL-2.0
-
-obj-$(CONFIG_JH71XX_PMU)	+= jh71xx_pmu.o