From patchwork Wed Jul 12 08:12:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 13309740 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89268EB64DD for ; Wed, 12 Jul 2023 08:14:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231368AbjGLIOn (ORCPT ); Wed, 12 Jul 2023 04:14:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232255AbjGLIOP (ORCPT ); Wed, 12 Jul 2023 04:14:15 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2116.outbound.protection.outlook.com [40.107.215.116]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F17A19BA; Wed, 12 Jul 2023 01:14:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jtE3fiTXW+95h7NrZq+ag+b6kSkTUdhGbCS/RNjpcEBXC5+o0q7kZxwROjIvBfnmzPgpm/aYGNPsLdA6fA76mgCMG5x/RY5iOMVleeP82KjgAYR+FhYKabmkZl498ohVIK8wpxU1WOFuAfQY2c0FeZI+bMEYenVMtZ56v0d787e/iXR9QmgxAMkAbXr1y9SYIg4Mh7PK6aEPNR8Ik3JF474fo+KJbDMRP5Y4ZmFR4rrB6vBfZnCrNxmd6hNJHs/cm3Z0k3HXPrsOS48+bgYyhoux8qTDLHlno91xYFowF+bqkgfxMyo1n6sqevgaa5oxwtHhwkIBtsRxJFZr3LGa6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qTSHy6tikfzk9mbKrw76CHlWfY85kX8JtLDPfmC6nfo=; b=NkP1psMVF69JIyq3JKpVLsgA/ZjPVw7tQmBWXMuSRz42lB2oCKQrISBGMYOklMyB9+1kDlPRw0kmXGT3NFY6JBGEsFVgl0KdhNxKRUovS0eprZvFAhz+WuxHuLTW5bB43vxpe+gatT5RsozN1c3/JCcP/oO70yQqT8Y2EYqsjCyOOocNVcnVxlkU0oEjob1Q3ysFqt0Uj86DkemOscc6b3qejUrvoJUMyc/P9eq3sGyduYuPFdYCKa2rqjW1WlZyY4HgCqxWTKEukFtq9pRaJQQOtqgFpctXK20geyfARqPNDnN0cmSNApIn3ixkieB1z86oA5KMRTAm2Io+kYXnhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qTSHy6tikfzk9mbKrw76CHlWfY85kX8JtLDPfmC6nfo=; b=TH3uZKxeRknU/OIyzjleKp2MZ6u94UATSyVRXm4PaajmwPuh5DI6lfef6ZgSfOUxfXpWa5omu40ReeaPlQcvuL2xCR6lvH3oiAgGB3BXzlrnmzn1jyKbuCXLl89jiDgZC/kenpyTCZCnz3tex2TlkKnsHJo8NgqlUuinVK86/mjyMOsTjZ3c1BuaYsq0CP+AqEp5XdAiN82+FSGYvLWyZ4l5H1bZUdlxTYfQEcNAzj4rcnlCQDvu8YYObapQEqAP68ULpQ2PWHTAIgwzXea2p6Kk7g4C7SdMtScXv6pbgq9PO6KpVO/twHvw/z0VVp/aRLpGi+Dsgwlz9hhhUblc6w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SG2PR06MB5382.apcprd06.prod.outlook.com (2603:1096:4:1d5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.20; Wed, 12 Jul 2023 08:14:06 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6565.028; Wed, 12 Jul 2023 08:14:06 +0000 From: Yangtao Li To: "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 09/27] thermal/drivers/spear: Convert to platform remove callback returning void Date: Wed, 12 Jul 2023 16:12:40 +0800 Message-Id: <20230712081258.29254-9-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230712081258.29254-1-frank.li@vivo.com> References: <20230712081258.29254-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR04CA0208.apcprd04.prod.outlook.com (2603:1096:4:187::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SG2PR06MB5382:EE_ X-MS-Office365-Filtering-Correlation-Id: e3ad1a3d-2f46-4668-680a-08db82aff62f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jh4N8cd1C0cb89OHY3/acIUzGasKd6FkgqlmWqMHXT2/ccQuivct2vF4ppfoHIW8Mm0gKMToOP0Y1j4VSlUBzWg8w+dDl+Crmr6EH/FUjwRkrzDJ0Hklg52dbpffcI7jS+j/Wnx59sSy7S6u1CS5rWUvCpGEjALBUDALvh2XBCrdLxa5QlQE7bPYkV/M6nSOnQbhJd0DTs/BTbBOtZfTFlUpJHJqA/k4sXsZqLS0ZYCL/9jDbyHMTqF1VUDroMXXvAOeZoi6+yRiTDcuVLezO9odCuw3EMXTLljqxaZOrQpwsZAV+CigCfZuXP9KObMaF/dG05pshwTprj27dqO90dy79AgLF/VXy7QLVCeIlaZjiwADHEyZ39c0XUe8sGdpBLXNdJfr4RFJff0hd8x0DFvy0KicYmUpuE9hrpUszT4nLDsd1fG+Ihu/b1VmuBO5VbDpg3RO44UtSSrBoxGBQEBLQEO4HsxdjQmaRJyu5+6LJJfrusrbxdpgNZV1ehppO2rKVgEWGRZOR2nYzNH1NA8WsjxIdNbQ+eUwi+cRnNAhBKd6O5/NJK+HHAqNf1V++4rwgGMdkSh5uhuZYNsGpPkz11WEA62yUMsNwWEMXIYIXKfNhLKFiGYWHj9nW+GZ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(366004)(136003)(376002)(346002)(39860400002)(451199021)(6666004)(52116002)(6486002)(478600001)(54906003)(110136005)(6506007)(1076003)(26005)(186003)(6512007)(2906002)(66946007)(41300700001)(66476007)(316002)(8936002)(66556008)(4326008)(5660300002)(38100700002)(38350700002)(8676002)(86362001)(36756003)(2616005)(83380400001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?m3jtXAhC3tTgtE7d4TaM1UKQjUr5?= =?utf-8?q?DZT/7BMNEVEFvrSQ0TN92zOpKcfcQJ2gAq7/1s35PmXyFQvyR9j3TmjX/n9A7miE5?= =?utf-8?q?I2UNKpqBKUGjF2U5U29DRQVHVsAzG/aj3zBoLtlb78bahLuAc1zBwJlbCsINEkU94?= =?utf-8?q?mmqMtSceDVh2RZxJeqwXVi6ZRZ/bqyH0ED7h7soWiHDwsmZHZTe6QX5KuG9BU8D3X?= =?utf-8?q?sX3/EqFyUUvxQqMUkd0BVr/KmQ8xPpJrKqzDnCZTfORrX6sK+tpEgiiYevLuARC5s?= =?utf-8?q?k3RBtpjH+wRtiIDD9McrM7h+dNCVfCNXjmSvmW+pNa7+URTDc8AoOQlfOlb4io7gn?= =?utf-8?q?MQjUOAbXbqEJ7qLHRSDtp/XD5GU5F5rtItWiFsmvuROo2VZhEn4hfEnK8W83KXD9u?= =?utf-8?q?foDwR7CYoWAlUbyxQmWsEzYJfkzRC8A6ZRNI6OxVaXkVohrtMdHQWE6SJldlDwM0N?= =?utf-8?q?CVq5PFZwRz9/UWO7PesXFGPISQKmqKkKJfag0feOGhQtUNUCK62ZeRjH/K2hqKEyn?= =?utf-8?q?qW/+T/rvz1sCtRPZYbcpj5BvnvbJTa52nr0FHqPaBP/eE6Ke9M80ai5JHbRnyHskv?= =?utf-8?q?yz5rcoZfnepyhzRlrVO6sY5chBVPfs9UsV4gC2u57VVAfnQP7YeuZWRBPkquMfpnH?= =?utf-8?q?eZvc8CxonD/vnsP+dg5T4PB+yxoHT/RC015/lAZCXRQgcQfzPGBCZ0EDan9iUsDqx?= =?utf-8?q?7A00iusy8zw19EGt62o4Ty4gJ/3Hu52p7776egenLyv2or7CA+dhT5cxe9mATCYf7?= =?utf-8?q?gFycbBnHcRX+fQiUAqireqvfJXHaLIq8BsvZ2C8J17IsBiKY2veW6jP3DxPLprdXP?= =?utf-8?q?+GjMUoOdSP3QmrN7w5NQCQW+IzGW5TFSI7vftmseIvxV04KtpkRJoxi6qgsrjsiN7?= =?utf-8?q?zzYn5QIvhCMB7sS9UEUcyxNfJQiUscQ/zDs7DjxPP5ehrQydJmxS/iDOkBsvE6iWE?= =?utf-8?q?VbutF5j8g5JQAuo9+lpfC/spqQxbZVOs1etiq1CCBS/PIP8vG2GCFE9frMgMuuc+i?= =?utf-8?q?G46et8uRkpOEhouH4iv4Dzprf8QBchFVSp6MfnasmpnvhudSxIKtjvIVE8+fAmnht?= =?utf-8?q?yC860bfBQdoi5IzUHGATvEnar6imPY7UAKRrIfjbJ2gKUC+bB5MFGiNgWj4ZQMxLE?= =?utf-8?q?HRWvx2vxFqynDTpkw7wpdeOvOVyG6EPPASYsl1FByoKfbGSU/Zrx3C04mQ/N8zW9J?= =?utf-8?q?0xSxSU9+DuMCkqnQe1cbfx7/GIODL5YPvaQbjdPZxvS75iifBl4JfY8zlCjnOmcAr?= =?utf-8?q?XTRlA4/TRbvfNi7IE37VOJ69s5S6RVHmGn0RmedRKbdyGyP3M3Sr6yXN3dqKQ7Bri?= =?utf-8?q?zkyKJUe+27aJpRT2qNFDOS0QNNu+cObPxwaDt0Q5R9TP3EuzSCW32900LscJnZxCY?= =?utf-8?q?l+3anwb4S3WeH/ZWjMhsX80JjAjXBzBNVcXhNeJ5HPsX1yKL1P0om6drmPDV4fON6?= =?utf-8?q?XsqxT/q2MO+KrEDb+IiNed16i99mpcBLsBoQKW4gkaJAnhP4EnsG2b6KAgTzRH9lA?= =?utf-8?q?76DJ2S4CvzDG?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3ad1a3d-2f46-4668-680a-08db82aff62f X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 08:14:06.5568 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HjIWdBJEGpkWuSHNx85MubFtVDRsAzON1Y8Kd8VcHiqA95e8e0qK6g0vXezoKF3yBomwM3MZmsdvgp8mkyAmFQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB5382 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/thermal/spear_thermal.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/thermal/spear_thermal.c b/drivers/thermal/spear_thermal.c index 6e78616a576e..843fa5c8e7c8 100644 --- a/drivers/thermal/spear_thermal.c +++ b/drivers/thermal/spear_thermal.c @@ -150,7 +150,7 @@ static int spear_thermal_probe(struct platform_device *pdev) return ret; } -static int spear_thermal_exit(struct platform_device *pdev) +static void spear_thermal_exit(struct platform_device *pdev) { unsigned int actual_mask = 0; struct thermal_zone_device *spear_thermal = platform_get_drvdata(pdev); @@ -163,8 +163,6 @@ static int spear_thermal_exit(struct platform_device *pdev) writel_relaxed(actual_mask & ~stdev->flags, stdev->thermal_base); clk_disable(stdev->clk); - - return 0; } static const struct of_device_id spear_thermal_id_table[] = { @@ -175,7 +173,7 @@ MODULE_DEVICE_TABLE(of, spear_thermal_id_table); static struct platform_driver spear_thermal_driver = { .probe = spear_thermal_probe, - .remove = spear_thermal_exit, + .remove_new = spear_thermal_exit, .driver = { .name = "spear_thermal", .pm = &spear_thermal_pm_ops,