| Message ID | 20230712103213.101770-3-manivannan.sadhasivam@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | viresh kumar |
| Headers | show |
| Series | UFS: Add OPP and interconnect support | expand |
On 12-07-23, 16:01, Manivannan Sadhasivam wrote: > Current limit of 16 will be exhausted by platforms specifying the frequency > for 9 clocks using opp-hz, like Qcom SDM845 SoC: 9 * 2 (64 bits) = 18 You missed mentioning why you are multiplying by 2 here (I suppose one place for /bits/ 64 and one for <freq>. Also full stop (.) is missing at the end. > So let's increase the limit to 32 which should be enough for most platforms > (hopefully). > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml > index 47e6f36b7637..e2f8f7af3cf4 100644 > --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml > +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml > @@ -56,7 +56,7 @@ patternProperties: > need to be configured and that is left for the implementation > specific binding. > minItems: 1 > - maxItems: 16 > + maxItems: 32 > items: > maxItems: 1 > > -- > 2.25.1
On Wed, Jul 12, 2023 at 04:09:21PM +0530, Viresh Kumar wrote: > On 12-07-23, 16:01, Manivannan Sadhasivam wrote: > > Current limit of 16 will be exhausted by platforms specifying the frequency > > for 9 clocks using opp-hz, like Qcom SDM845 SoC: 9 * 2 (64 bits) = 18 > > You missed mentioning why you are multiplying by 2 here (I suppose one > place for /bits/ 64 and one for <freq>. > > Also full stop (.) is missing at the end. > Ok. - Mani > > So let's increase the limit to 32 which should be enough for most platforms > > (hopefully). > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > --- > > Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml > > index 47e6f36b7637..e2f8f7af3cf4 100644 > > --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml > > +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml > > @@ -56,7 +56,7 @@ patternProperties: > > need to be configured and that is left for the implementation > > specific binding. > > minItems: 1 > > - maxItems: 16 > > + maxItems: 32 > > items: > > maxItems: 1 > > > > -- > > 2.25.1 > > -- > viresh
On Wed, Jul 12, 2023 at 04:01:57PM +0530, Manivannan Sadhasivam wrote: > Current limit of 16 will be exhausted by platforms specifying the frequency > for 9 clocks using opp-hz, like Qcom SDM845 SoC: 9 * 2 (64 bits) = 18 Are you sure about that? opp-hz is defined as uint64-matrix, so 16 64-bit entries should already be allowed. It doesn't matter how the .dts is encoded (it used to though). > > So let's increase the limit to 32 which should be enough for most platforms > (hopefully). > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml > index 47e6f36b7637..e2f8f7af3cf4 100644 > --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml > +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml > @@ -56,7 +56,7 @@ patternProperties: > need to be configured and that is left for the implementation > specific binding. > minItems: 1 > - maxItems: 16 > + maxItems: 32 > items: > maxItems: 1 > > -- > 2.25.1 >
On Fri, Jul 14, 2023 at 10:17:33AM -0600, Rob Herring wrote: > On Wed, Jul 12, 2023 at 04:01:57PM +0530, Manivannan Sadhasivam wrote: > > Current limit of 16 will be exhausted by platforms specifying the frequency > > for 9 clocks using opp-hz, like Qcom SDM845 SoC: 9 * 2 (64 bits) = 18 > > Are you sure about that? opp-hz is defined as uint64-matrix, so 16 > 64-bit entries should already be allowed. It doesn't matter how the .dts > is encoded (it used to though). > Yes, 16 64bit entries are allowed, but SDM845 will add 18 entries (due to 9 clocks) and hence this patch. Did I miss anything? - Mani > > > > So let's increase the limit to 32 which should be enough for most platforms > > (hopefully). > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > --- > > Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml > > index 47e6f36b7637..e2f8f7af3cf4 100644 > > --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml > > +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml > > @@ -56,7 +56,7 @@ patternProperties: > > need to be configured and that is left for the implementation > > specific binding. > > minItems: 1 > > - maxItems: 16 > > + maxItems: 32 > > items: > > maxItems: 1 > > > > -- > > 2.25.1 > >
diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml index 47e6f36b7637..e2f8f7af3cf4 100644 --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml @@ -56,7 +56,7 @@ patternProperties: need to be configured and that is left for the implementation specific binding. minItems: 1 - maxItems: 16 + maxItems: 32 items: maxItems: 1
Current limit of 16 will be exhausted by platforms specifying the frequency for 9 clocks using opp-hz, like Qcom SDM845 SoC: 9 * 2 (64 bits) = 18 So let's increase the limit to 32 which should be enough for most platforms (hopefully). Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)