Message ID | 20230721-topic-icc_bindings-v1-4-93e2bc728fb7@linaro.org (mailing list archive) |
---|---|
State | Handled Elsewhere, archived |
Headers | show |
Series | Update RPM ICC bindings | expand |
On 21/07/2023 15:54, Konrad Dybcio wrote: > Separate out QCS404 icc bindings from the common file and fix the > clocks description by removing the wrong internal RPM bus clock > representation that we've been carrying for years. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > .../bindings/interconnect/qcom,qcs404.yaml | 52 ++++++++++++++++++++++ > .../devicetree/bindings/interconnect/qcom,rpm.yaml | 6 --- > 2 files changed, 52 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,qcs404.yaml b/Documentation/devicetree/bindings/interconnect/qcom,qcs404.yaml > new file mode 100644 > index 000000000000..aff2daa55802 > --- /dev/null > +++ b/Documentation/devicetree/bindings/interconnect/qcom,qcs404.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/interconnect/qcom,qcs404.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm QCS404 Network-On-Chip interconnect > + > +maintainers: > + - Konrad Dybcio <konradybcio@kernel.org> > + > +description: | > + The Qualcomm QCS404 interconnect providers support adjusting the > + bandwidth requirements between the various NoC fabrics. > + > +allOf: > + - $ref: qcom,rpm-common.yaml# > + > +properties: > + compatible: > + enum: > + - qcom,qcs404-bimc > + - qcom,qcs404-pcnoc > + - qcom,qcs404-snoc I am not sure it is reasonable to keep such short bindings each in its own file. Maybe 8916 and qcs404 should be left in common file? > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/qcom,rpmcc.h> > + > + snoc: interconnect@580000 { > + compatible = "qcom,qcs404-snoc"; > + reg = <0x00580000 0x23080>; > + #interconnect-cells = <1>; > + }; > + > + pcnoc: interconnect@500000 { > + compatible = "qcom,qcs404-pcnoc"; > + reg = <0x00500000 0x15080>; > + #interconnect-cells = <1>; > + }; > + > + bimc: interconnect@400000 { > + compatible = "qcom,qcs404-bimc"; > + reg = <0x00400000 0x80000>; > + #interconnect-cells = <1>; > + }; Keep only one example. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/interconnect/qcom,qcs404.yaml b/Documentation/devicetree/bindings/interconnect/qcom,qcs404.yaml new file mode 100644 index 000000000000..aff2daa55802 --- /dev/null +++ b/Documentation/devicetree/bindings/interconnect/qcom,qcs404.yaml @@ -0,0 +1,52 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/interconnect/qcom,qcs404.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm QCS404 Network-On-Chip interconnect + +maintainers: + - Konrad Dybcio <konradybcio@kernel.org> + +description: | + The Qualcomm QCS404 interconnect providers support adjusting the + bandwidth requirements between the various NoC fabrics. + +allOf: + - $ref: qcom,rpm-common.yaml# + +properties: + compatible: + enum: + - qcom,qcs404-bimc + - qcom,qcs404-pcnoc + - qcom,qcs404-snoc + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/clock/qcom,rpmcc.h> + + snoc: interconnect@580000 { + compatible = "qcom,qcs404-snoc"; + reg = <0x00580000 0x23080>; + #interconnect-cells = <1>; + }; + + pcnoc: interconnect@500000 { + compatible = "qcom,qcs404-pcnoc"; + reg = <0x00500000 0x15080>; + #interconnect-cells = <1>; + }; + + bimc: interconnect@400000 { + compatible = "qcom,qcs404-bimc"; + reg = <0x00400000 0x80000>; + #interconnect-cells = <1>; + }; diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml index 788c5e88445a..58075c23f9f9 100644 --- a/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml @@ -31,9 +31,6 @@ properties: - qcom,msm8996-mnoc - qcom,msm8996-pnoc - qcom,msm8996-snoc - - qcom,qcs404-bimc - - qcom,qcs404-pcnoc - - qcom,qcs404-snoc - qcom,sdm660-a2noc - qcom,sdm660-bimc - qcom,sdm660-cnoc @@ -114,9 +111,6 @@ allOf: - qcom,msm8996-cnoc - qcom,msm8996-pnoc - qcom,msm8996-snoc - - qcom,qcs404-bimc - - qcom,qcs404-pcnoc - - qcom,qcs404-snoc - qcom,sdm660-bimc - qcom,sdm660-cnoc - qcom,sdm660-gnoc
Separate out QCS404 icc bindings from the common file and fix the clocks description by removing the wrong internal RPM bus clock representation that we've been carrying for years. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- .../bindings/interconnect/qcom,qcs404.yaml | 52 ++++++++++++++++++++++ .../devicetree/bindings/interconnect/qcom,rpm.yaml | 6 --- 2 files changed, 52 insertions(+), 6 deletions(-)