From patchwork Mon Aug 7 06:23:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xuewen Yan X-Patchwork-Id: 13343088 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 406A4EB64DD for ; Mon, 7 Aug 2023 06:24:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230294AbjHGGYo (ORCPT ); Mon, 7 Aug 2023 02:24:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229487AbjHGGYn (ORCPT ); Mon, 7 Aug 2023 02:24:43 -0400 Received: from SHSQR01.spreadtrum.com (mx1.unisoc.com [222.66.158.135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE6CC10F9; Sun, 6 Aug 2023 23:24:41 -0700 (PDT) Received: from dlp.unisoc.com ([10.29.3.86]) by SHSQR01.spreadtrum.com with ESMTP id 3776O0je067960; Mon, 7 Aug 2023 14:24:00 +0800 (+08) (envelope-from Xuewen.Yan@unisoc.com) Received: from SHDLP.spreadtrum.com (bjmbx01.spreadtrum.com [10.0.64.7]) by dlp.unisoc.com (SkyGuard) with ESMTPS id 4RK5nq5kmwz2P65sW; Mon, 7 Aug 2023 14:22:07 +0800 (CST) Received: from BJ10918NBW01.spreadtrum.com (10.0.73.72) by BJMBX01.spreadtrum.com (10.0.64.7) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Mon, 7 Aug 2023 14:23:57 +0800 From: Xuewen Yan To: , , CC: , , , Subject: [PATCH] PM: QOS: Always use "kstrtos32_from_user()" in cpu_latency_qos_write() Date: Mon, 7 Aug 2023 14:23:45 +0800 Message-ID: <20230807062345.490-1-xuewen.yan@unisoc.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.0.73.72] X-ClientProxiedBy: SHCAS01.spreadtrum.com (10.0.1.201) To BJMBX01.spreadtrum.com (10.0.64.7) X-MAIL: SHSQR01.spreadtrum.com 3776O0je067960 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org In cpu_latency_qos_write, there is a judgment on whether the count value is equal to sizeof(s32). This means that when user write 100~999, it would get error value because it would call the "copy_from_user()" instead of "kstrtos32". Just like: # echo 500 > /dev/cpu_dma_latency [T4893] write: qos value=170930229 [T4893] write: count value=4 [T4893] write: qos value=170930226 [T4893] write: count value=4 To prevent this happening, delete the "copy_from_user()" and always use "kstrtos32_from_user()". Signed-off-by: Xuewen Yan --- kernel/power/qos.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/kernel/power/qos.c b/kernel/power/qos.c index 782d3b41c1f3..21a2f873e921 100644 --- a/kernel/power/qos.c +++ b/kernel/power/qos.c @@ -379,17 +379,11 @@ static ssize_t cpu_latency_qos_write(struct file *filp, const char __user *buf, size_t count, loff_t *f_pos) { s32 value; + int ret; - if (count == sizeof(s32)) { - if (copy_from_user(&value, buf, sizeof(s32))) - return -EFAULT; - } else { - int ret; - - ret = kstrtos32_from_user(buf, count, 16, &value); - if (ret) - return ret; - } + ret = kstrtos32_from_user(buf, count, 16, &value); + if (ret) + return ret; cpu_latency_qos_update_request(filp->private_data, value);