| Message ID | 20230814180921.3336-1-aboutphysycs@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Daniel Lezcano |
| Headers | show |
| Series | thermal: generic-adc: removed unneeded call to platform_set_drvdata() | expand |
On Mon, Aug 14, 2023 at 9:09 PM Andrei Coardos <aboutphysycs@gmail.com> wrote: > > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call to access the private data of the driver. Also, > the private data is defined in this driver, so there is no risk of it being > accessed outside of this driver file. > Reviewed-by: Alexandru Ardelean <alex@shruggie.ro> > Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com> > --- > drivers/thermal/thermal-generic-adc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/thermal/thermal-generic-adc.c b/drivers/thermal/thermal-generic-adc.c > index f4f1a04f8c0f..1717e4a19dcb 100644 > --- a/drivers/thermal/thermal-generic-adc.c > +++ b/drivers/thermal/thermal-generic-adc.c > @@ -142,7 +142,6 @@ static int gadc_thermal_probe(struct platform_device *pdev) > return ret; > > gti->dev = &pdev->dev; > - platform_set_drvdata(pdev, gti); > > gti->tz_dev = devm_thermal_of_zone_register(&pdev->dev, 0, gti, > &gadc_thermal_ops); > -- > 2.34.1 >
diff --git a/drivers/thermal/thermal-generic-adc.c b/drivers/thermal/thermal-generic-adc.c index f4f1a04f8c0f..1717e4a19dcb 100644 --- a/drivers/thermal/thermal-generic-adc.c +++ b/drivers/thermal/thermal-generic-adc.c @@ -142,7 +142,6 @@ static int gadc_thermal_probe(struct platform_device *pdev) return ret; gti->dev = &pdev->dev; - platform_set_drvdata(pdev, gti); gti->tz_dev = devm_thermal_of_zone_register(&pdev->dev, 0, gti, &gadc_thermal_ops);
This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file. Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com> --- drivers/thermal/thermal-generic-adc.c | 1 - 1 file changed, 1 deletion(-)